[M] Change in dart/sdk[main]: Add documentation for the principle of consistency
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Jan 8, 2026, 1:05:28 PM (3 days ago) Jan 8
to Brian Wilkerson, Keerti Parthasarathy, Phil Quitslund, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy, Phil Quitslund and Samuel Rawlins
Brian Wilkerson voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Keerti Parthasarathy
- Phil Quitslund
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Jan 8, 2026, 1:20:35 PM (3 days ago) Jan 8
to Brian Wilkerson, Commit Queue, Keerti Parthasarathy, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Keerti Parthasarathy and Phil Quitslund
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved
Thanks Brian, this reads really well!
Related details
Attention is currently required from:
- Brian Wilkerson
- Keerti Parthasarathy
- Phil Quitslund
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keerti Parthasarathy (Gerrit)
Jan 8, 2026, 5:16:54 PM (2 days ago) Jan 8
to Brian Wilkerson, Samuel Rawlins, Commit Queue, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Phil Quitslund
Keerti Parthasarathy voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
- Phil Quitslund
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Phil Quitslund (Gerrit)
Jan 8, 2026, 8:10:11 PM (2 days ago) Jan 8
to Brian Wilkerson, Danny Tuppeny, Keerti Parthasarathy, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Phil Quitslund voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Phil Quitslund (Gerrit)
Jan 8, 2026, 8:10:19 PM (2 days ago) Jan 8
to Brian Wilkerson, Danny Tuppeny, Keerti Parthasarathy, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Phil Quitslund added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Phil Quitslund . resolved
Nice!
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danny Tuppeny (Gerrit)
Jan 9, 2026, 4:51:50 AM (2 days ago) Jan 9
to Brian Wilkerson, Phil Quitslund, Keerti Parthasarathy, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Danny Tuppeny added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Danny Tuppeny . resolved
lgtm :-)
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Jan 9, 2026, 10:28:00 AM (2 days ago) Jan 9
to Brian Wilkerson, Phil Quitslund, Danny Tuppeny, Keerti Parthasarathy, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Jan 9, 2026, 10:28:14 AM (2 days ago) Jan 9
to Brian Wilkerson, Phil Quitslund, Danny Tuppeny, Keerti Parthasarathy, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add documentation for the principle of consistency
This feels kind of brief, especially compared to the language fidelity
principle. In addition to improvements to the existing text, please let
me know what needs to be added or expanded on.
Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/471402
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Phil Quitslund <pquit...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Files:
- A pkg/analysis_server/doc/design/principles/consistency.md
Change size: M
Delta: 1 file changed, 68 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Phil Quitslund, +1 by Keerti Parthasarathy, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages