[M] Change in dart/sdk[main]: Add documentation for the principle of consistency

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
Jan 8, 2026, 1:05:28 PM (3 days ago) Jan 8
to Brian Wilkerson, Keerti Parthasarathy, Phil Quitslund, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy, Phil Quitslund and Samuel Rawlins

Brian Wilkerson voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keerti Parthasarathy
  • Phil Quitslund
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Gerrit-Change-Number: 471402
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Phil Quitslund <pquit...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Thu, 08 Jan 2026 18:05:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Jan 8, 2026, 1:20:35 PM (3 days ago) Jan 8
to Brian Wilkerson, Commit Queue, Keerti Parthasarathy, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Keerti Parthasarathy and Phil Quitslund

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved

Thanks Brian, this reads really well!

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Keerti Parthasarathy
  • Phil Quitslund
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Gerrit-Change-Number: 471402
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Phil Quitslund <pquit...@google.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Thu, 08 Jan 2026 18:20:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Keerti Parthasarathy (Gerrit)

unread,
Jan 8, 2026, 5:16:54 PM (2 days ago) Jan 8
to Brian Wilkerson, Samuel Rawlins, Commit Queue, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Phil Quitslund

Keerti Parthasarathy voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Phil Quitslund
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Gerrit-Change-Number: 471402
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Phil Quitslund <pquit...@google.com>
Gerrit-Comment-Date: Thu, 08 Jan 2026 22:16:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Phil Quitslund (Gerrit)

unread,
Jan 8, 2026, 8:10:11 PM (2 days ago) Jan 8
to Brian Wilkerson, Danny Tuppeny, Keerti Parthasarathy, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

Phil Quitslund voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Gerrit-Change-Number: 471402
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 01:10:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Phil Quitslund (Gerrit)

unread,
Jan 8, 2026, 8:10:19 PM (2 days ago) Jan 8
to Brian Wilkerson, Danny Tuppeny, Keerti Parthasarathy, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

Phil Quitslund added 1 comment

Patchset-level comments
Phil Quitslund . resolved

Nice!

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Gerrit-Change-Number: 471402
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 01:10:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Danny Tuppeny (Gerrit)

unread,
Jan 9, 2026, 4:51:50 AM (2 days ago) Jan 9
to Brian Wilkerson, Phil Quitslund, Keerti Parthasarathy, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

Danny Tuppeny added 1 comment

Patchset-level comments
Danny Tuppeny . resolved

lgtm :-)

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Gerrit-Change-Number: 471402
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 09:51:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Jan 9, 2026, 10:28:00 AM (2 days ago) Jan 9
to Brian Wilkerson, Phil Quitslund, Danny Tuppeny, Keerti Parthasarathy, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Brian Wilkerson voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Gerrit-Change-Number: 471402
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 15:27:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Jan 9, 2026, 10:28:14 AM (2 days ago) Jan 9
to Brian Wilkerson, Phil Quitslund, Danny Tuppeny, Keerti Parthasarathy, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
Add documentation for the principle of consistency

This feels kind of brief, especially compared to the language fidelity
principle. In addition to improvements to the existing text, please let
me know what needs to be added or expanded on.
Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Phil Quitslund <pquit...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Files:
  • A pkg/analysis_server/doc/design/principles/consistency.md
Change size: M
Delta: 1 file changed, 68 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Phil Quitslund, +1 by Keerti Parthasarathy, +1 by Samuel Rawlins
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I30705acb705a4aa94c8ba2c70757d3f44e2e09b3
Gerrit-Change-Number: 471402
Gerrit-PatchSet: 2
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <da...@tuppeny.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages