[M] Change in dart/sdk[main]: [ Service ] Cleanup dart_runtime_service* logging and DDS state

1 view

Skip to first unread message

Ben Konyi (Gerrit)

unread,

Mar 27, 2026, 11:50:33 AM (3 days ago) Mar 27

to Nicholas Shahan, Jessy Yameogo, rev...@dartlang.org

Attention needed from Jessy Yameogo and Nicholas Shahan

Ben Konyi voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Jessy Yameogo
Nicholas Shahan

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nicholas Shahan (Gerrit)

unread,

2:16 PM (6 hours ago) 2:16 PM

to Ben Konyi, Commit Queue, Jessy Yameogo, rev...@dartlang.org

Attention needed from Ben Konyi and Jessy Yameogo

Nicholas Shahan added 4 comments

File pkg/dart_runtime_service/lib/src/dart_runtime_service.dart

Line 93, Patchset 1 (Latest):

      // Adds a trailing '/' for backwards compatibility.
      '',

Nicholas Shahan . unresolved

Are there certain tools that expect this? Do we expect this will be this way forever or is there some future where we don't need this support anymore?

Line 190, Patchset 1 (Latest): // TODO(bkonyi): respect silenceOutput

Nicholas Shahan . unresolved

Does this count as done now?

Line 197, Patchset 1 (Latest): 'silenceServiceInput: $silenceServiceOutput -> $silenceOutput',

Nicholas Shahan . unresolved

What is this log message trying to convey?

Line 199, Patchset 1 (Latest): silenceServiceOutput = silenceServiceOutput;

Nicholas Shahan . unresolved

Should this be?
```suggestion
      silenceServiceOutput = silenceOutput;
```

Open in Gerrit

Related details

Attention is currently required from:

Ben Konyi
Jessy Yameogo

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages