[XS] Change in dart/sdk[main]: [co19] Roll co19 to 457888d41cd357469854343278e2c4202e6f1125

0 views
Skip to first unread message

Sergey Grekhov (Gerrit)

unread,
Mar 13, 2026, 3:41:16 AMMar 13
to Alexander Thomas, Erik Ernst, rev...@dartlang.org
Attention needed from Alexander Thomas and Erik Ernst

Sergey Grekhov has uploaded the change for review

Sergey Grekhov would like Alexander Thomas and Erik Ernst to review this change.

Commit message

[co19] Roll co19 to 457888d41cd357469854343278e2c4202e6f1125

2026-03-12 sgrek...@gmail.com dart-lang/co19#3203. Update `VM/primary_constructors_*` tests according to the current behavior of the debugger (dart-lang/co19#3654)
2026-03-11 sgrek...@gmail.com dart-lang/co19#3182. Add test for augmentations with no bodies (dart-lang/co19#3659)
2026-03-11 sgrek...@gmail.com Fixes dart-langdart-lang/co19#3657. Allow mixins and extensions with `;` as a body (dart-lang/co19#3658)
2026-03-11 sgrek...@gmail.com dart-lang/co19#3182. Add tests for augmentation and private named parameters (dart-lang/co19#3656)
2026-03-10 sgrek...@gmail.com dart-lang/co19#3203. Update line numbers in primary constructors VM tests (dart-lang/co19#3653)
2026-03-09 sgrek...@gmail.com dart-lang/co19#3641. Add more tests for permitted use of type `void`. Part 2. (dart-lang/co19#3652)
2026-03-09 sgrek...@gmail.com Fixes dart-lang/co19#3650. Update expected errors (dart-lang/co19#3651)
2026-03-09 sgrek...@gmail.com Fixes dart-lang/co19#3648. Update expected error locations in grammar_A03_t02.dart (dart-lang/co19#3649)
2026-03-06 sgrek...@gmail.com dart-lang/co19#3182. Add tests for variables with no initializer (dart-lang/co19#3646)

R=at...@google.com, eer...@google.com
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I277780a9060e55f904751c3d266540fc357138f3

Change information

Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Erik Ernst
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I277780a9060e55f904751c3d266540fc357138f3
Gerrit-Change-Number: 487760
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Mar 13, 2026, 4:52:02 AMMar 13
to Sergey Grekhov, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas and Sergey Grekhov

Erik Ernst voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I277780a9060e55f904751c3d266540fc357138f3
Gerrit-Change-Number: 487760
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 08:51:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sergey Grekhov (Gerrit)

unread,
Mar 13, 2026, 4:59:54 AMMar 13
to Erik Ernst, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas

Sergey Grekhov added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sergey Grekhov . resolved

Can be landed.

New failures:
co19/LanguageFeatures/Primary-constructors/grammar_A01_t04 - https://github.com/dart-lang/sdk/issues/62885
co19/LanguageFeatures/Primary-constructors/grammar_A01_t05 - https://github.com/dart-lang/sdk/issues/62885
co19/Language/Types/Type_Void/permitted_use_A15_t01 - https://github.com/dart-lang/sdk/issues/62886
co19/Language/Types/Type_Void/permitted_use_A15_t02 - https://github.com/dart-lang/sdk/issues/62858
co19/Language/Types/Type_Void/permitted_use_A15_t04 - https://github.com/dart-lang/sdk/issues/62858

All other new failures are caused by the tests for Augmentations. This feature is not implemented yet.

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I277780a9060e55f904751c3d266540fc357138f3
Gerrit-Change-Number: 487760
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 08:59:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Mar 13, 2026, 5:01:40 AMMar 13
to Sergey Grekhov, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas and Sergey Grekhov

Erik Ernst added 2 comments

Patchset-level comments
Erik Ernst . resolved

Approved.

Sergey Grekhov . resolved

Can be landed.

New failures:
co19/LanguageFeatures/Primary-constructors/grammar_A01_t04 - https://github.com/dart-lang/sdk/issues/62885
co19/LanguageFeatures/Primary-constructors/grammar_A01_t05 - https://github.com/dart-lang/sdk/issues/62885
co19/Language/Types/Type_Void/permitted_use_A15_t01 - https://github.com/dart-lang/sdk/issues/62886
co19/Language/Types/Type_Void/permitted_use_A15_t02 - https://github.com/dart-lang/sdk/issues/62858
co19/Language/Types/Type_Void/permitted_use_A15_t04 - https://github.com/dart-lang/sdk/issues/62858

All other new failures are caused by the tests for Augmentations. This feature is not implemented yet.

Erik Ernst

Approved.

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I277780a9060e55f904751c3d266540fc357138f3
Gerrit-Change-Number: 487760
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 09:01:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sergey Grekhov <sgrek...@gmail.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Thomas (Gerrit)

unread,
Mar 13, 2026, 5:54:40 AMMar 13
to Sergey Grekhov, Erik Ernst, Commit Queue, rev...@dartlang.org
Attention needed from Sergey Grekhov

Alexander Thomas voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sergey Grekhov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I277780a9060e55f904751c3d266540fc357138f3
    Gerrit-Change-Number: 487760
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Alexander Thomas <at...@google.com>
    Gerrit-Reviewer: Erik Ernst <eer...@google.com>
    Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Comment-Date: Fri, 13 Mar 2026 09:54:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Mar 13, 2026, 6:34:03 AMMar 13
    to Sergey Grekhov, Alexander Thomas, Erik Ernst, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [co19] Roll co19 to 457888d41cd357469854343278e2c4202e6f1125

    2026-03-12 sgrek...@gmail.com dart-lang/co19#3203. Update `VM/primary_constructors_*` tests according to the current behavior of the debugger (dart-lang/co19#3654)
    2026-03-11 sgrek...@gmail.com dart-lang/co19#3182. Add test for augmentations with no bodies (dart-lang/co19#3659)
    2026-03-11 sgrek...@gmail.com Fixes dart-langdart-lang/co19#3657. Allow mixins and extensions with `;` as a body (dart-lang/co19#3658)
    2026-03-11 sgrek...@gmail.com dart-lang/co19#3182. Add tests for augmentation and private named parameters (dart-lang/co19#3656)
    2026-03-10 sgrek...@gmail.com dart-lang/co19#3203. Update line numbers in primary constructors VM tests (dart-lang/co19#3653)
    2026-03-09 sgrek...@gmail.com dart-lang/co19#3641. Add more tests for permitted use of type `void`. Part 2. (dart-lang/co19#3652)
    2026-03-09 sgrek...@gmail.com Fixes dart-lang/co19#3650. Update expected errors (dart-lang/co19#3651)
    2026-03-09 sgrek...@gmail.com Fixes dart-lang/co19#3648. Update expected error locations in grammar_A03_t02.dart (dart-lang/co19#3649)
    2026-03-06 sgrek...@gmail.com dart-lang/co19#3182. Add tests for variables with no initializer (dart-lang/co19#3646)

    R=at...@google.com, eer...@google.com
    Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
    Change-Id: I277780a9060e55f904751c3d266540fc357138f3
    Reviewed-by: Alexander Thomas <at...@google.com>
    Reviewed-by: Erik Ernst <eer...@google.com>
    Auto-Submit: Sergey Grekhov <sgrek...@gmail.com>
    Commit-Queue: Alexander Thomas <at...@google.com>
    Files:
    • M DEPS
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alexander Thomas, +1 by Erik Ernst
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I277780a9060e55f904751c3d266540fc357138f3
    Gerrit-Change-Number: 487760
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Alexander Thomas <at...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages