[L] Change in dart/sdk[main]: [DAS] Fixes dot shorthand completions when feature is disabled

0 views

Skip to first unread message

Felipe Morschel (Gerrit)

unread,

Jan 9, 2026, 10:45:39 PM (2 days ago) Jan 9

to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Fixes dot shorthand completions when feature is disabled

Fixes: https://github.com/dart-lang/sdk/issues/61983

Change-Id: Id5901b1094e2d9b18bc2ab3c279ddc94f6063eb3

Change information

Files:

M pkg/analysis_server/lib/src/handler/legacy/completion_utils.dart
M pkg/analysis_server/lib/src/lsp/completion_utils.dart
M pkg/analysis_server/lib/src/services/completion/dart/candidate_suggestion.dart
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
M pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
M pkg/analysis_server/lib/src/services/completion/dart/relevance_computer.dart
M pkg/analysis_server/lib/src/services/snippets/dart_snippet_request.dart
M pkg/analysis_server/test/services/completion/dart/location/dot_shorthand_constructor_invocation_test.dart
M pkg/analyzer_plugin/lib/src/utilities/completion/completion_target.dart
M pkg/analyzer_plugin/test/utilities/completion/completion_contributor_util.dart

Change size: L

Delta: 11 files changed, 355 insertions(+), 61 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

Jan 10, 2026, 12:17:42 PM (yesterday) Jan 10

to Felipe Morschel, Kallen Tu, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Felipe Morschel and Kallen Tu

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review

1 comment

File pkg/analysis_server/lib/src/services/completion/dart/candidate_suggestion.dart

Line 1361, Patchset 1 (Latest): /// Fixes dot-shorthand completions when the feature is not enabled.

Samuel Rawlins . unresolved

Instead of "fixes", can we write something maybe like "Supports", and I think the idea is that this bool allows us to property suggest dot-shorthands when they're allowed, and not dot-shorthands when they are not.

Open in Gerrit

Related details

Attention is currently required from:

Felipe Morschel
Kallen Tu

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages