[XS] Change in dart/sdk[main]: DeCo. Don't remove experiment from shared experimentsForTests.
0 views
Skip to first unread message
Phil Quitslund (Gerrit)
Dec 1, 2025, 6:45:59 PM (22 hours ago) Dec 1
to Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Phil Quitslund added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File pkg/analyzer_testing/lib/experiments/experiments.dart
Line 17, Patchset 1 (Latest):
List<String> experimentsForTests = List.unmodifiable([Phil Quitslund . resolved
Good call.
Related details
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Phil Quitslund (Gerrit)
Dec 1, 2025, 6:46:03 PM (22 hours ago) Dec 1
to Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Phil Quitslund voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 1, 2025, 6:47:10 PM (22 hours ago) Dec 1
to Phil Quitslund, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 1, 2025, 7:09:21 PM (22 hours ago) Dec 1
to Konstantin Shcheglov, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
DeCo. Don't remove experiment from shared experimentsForTests.
Change-Id: If746609320113a42c161021f7c7328cf79bd46fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465483
Reviewed-by: Phil Quitslund <pquit...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analyzer_testing/lib/experiments/experiments.dart
- M pkg/linter/test/rules/avoid_final_parameters_test.dart
Change size: XS
Delta: 2 files changed, 5 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Phil Quitslund
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages