[S] Change in dart/sdk[main]: [vm] Fix alignment for snapshots linked into the main binary.

0 views
Skip to first unread message

Ryan Macnak (Gerrit)

unread,
10:52 AM (2 hours ago) 10:52 AM
to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev

Ryan Macnak voted and added 1 comment

Votes added by Ryan Macnak

Commit-Queue+1

1 comment

File runtime/bin/snapshot_in.cc
Line 1, Patchset 3 (Parent):// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
Ryan Macnak . resolved

Last use removed in cl/903497626.

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Aprelev
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I819d035846191aeac441a574302b65674261cc9e
Gerrit-Change-Number: 497105
Gerrit-PatchSet: 5
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Alexander Aprelev <a...@google.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 14:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Aprelev (Gerrit)

unread,
11:10 AM (2 hours ago) 11:10 AM
to Ryan Macnak, Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak

Alexander Aprelev voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Macnak
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I819d035846191aeac441a574302b65674261cc9e
Gerrit-Change-Number: 497105
Gerrit-PatchSet: 5
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 15:10:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ryan Macnak (Gerrit)

unread,
11:26 AM (2 hours ago) 11:26 AM
to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org

Ryan Macnak voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I819d035846191aeac441a574302b65674261cc9e
Gerrit-Change-Number: 497105
Gerrit-PatchSet: 5
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 15:25:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
11:26 AM (2 hours ago) 11:26 AM
to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org, vm-...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[vm] Fix alignment for snapshots linked into the main binary.

TEST=ci
Change-Id: I819d035846191aeac441a574302b65674261cc9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/497105
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Files:
  • D runtime/bin/snapshot_in.cc
  • M runtime/tools/bin_to_assembly.py
  • M runtime/tools/bin_to_coff.py
  • M runtime/vm/image_snapshot.cc
Change size: S
Delta: 4 files changed, 9 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alexander Aprelev
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I819d035846191aeac441a574302b65674261cc9e
Gerrit-Change-Number: 497105
Gerrit-PatchSet: 6
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages