[XL] Change in dart/sdk[main]: [DAS] Fixes type argument handling for `Create function/method/operator`
Felipe Morschel (Gerrit)
Felipe Morschel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[DAS] Fixes type argument handling for `Create function/method/operator`
Change information
- M pkg/analysis_server/lib/src/services/correction/dart/create_function.dart
- M pkg/analysis_server/lib/src/services/correction/dart/create_method.dart
- M pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart
- M pkg/analysis_server/lib/src/services/correction/dart/create_operator.dart
- M pkg/analysis_server/lib/src/utilities/extensions/dart_type.dart
- M pkg/analysis_server/test/src/services/correction/fix/create_function_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/create_operator_test.dart
- M pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart
- A pkg/analysis_server_plugin/lib/src/utilities/extensions/dart_type.dart
- M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
- M pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
Only marked as WIP because I'd prefer to land https://dart-review.googlesource.com/c/sdk/+/459521 first. Thanks!
Related details
- Brian Wilkerson
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Felipe Morschel voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
- Brian Wilkerson
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
I've rebased this.
Can I get reviews here please? CC @brianwi...@google.com and @sraw...@google.com. Thanks a lot!
Related details
- Brian Wilkerson
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Samuel Rawlins voted and added 3 comments![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
3 comments
List<TypeParameterElement>? typeParametersList;Can this be
```
var typeParametersList = typeParametersSet?.toList();
```
bool onSameLine(int offset1, int offset2) {This could be a proper method on LineInfo. I grepped around and found some other possible cases. And it would be nice to factor a few changes out from this large CL 😄
```
git grep 'lineNumber.*==' pkg/{analysis_server,analyzer_plugin,analysis_server_plugin,linter,analyzer}
```
```
git grep '==.*lineNumber' pkg/{analysis_server,analyzer_plugin,analysis_server_plugin,linter,analyzer}
```
Related details
- Brian Wilkerson
- Felipe Morschel
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
bool onSameLine(int offset1, int offset2) {This could be a proper method on LineInfo. I grepped around and found some other possible cases. And it would be nice to factor a few changes out from this large CL 😄
```
git grep 'lineNumber.*==' pkg/{analysis_server,analyzer_plugin,analysis_server_plugin,linter,analyzer}
``````
git grep '==.*lineNumber' pkg/{analysis_server,analyzer_plugin,analysis_server_plugin,linter,analyzer}
```
Great idea! Here it is the new CL. I'll come back to this one once that one lands https://dart-review.googlesource.com/c/sdk/+/471061.
Related details
- Brian Wilkerson
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Felipe Morschel voted and added 3 comments![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
3 comments
Patchset 5 is related to the changes Sam requested and patchset 6 is generating `api.txt` to fix the broken tests.
Can this be
```
var typeParametersList = typeParametersSet?.toList();
```
Yes, thanks! I think I was originally doing more work there but not anymore. Great catch!
Felipe MorschelThis could be a proper method on LineInfo. I grepped around and found some other possible cases. And it would be nice to factor a few changes out from this large CL 😄
```
git grep 'lineNumber.*==' pkg/{analysis_server,analyzer_plugin,analysis_server_plugin,linter,analyzer}
``````
git grep '==.*lineNumber' pkg/{analysis_server,analyzer_plugin,analysis_server_plugin,linter,analyzer}
```
Great idea! Here it is the new CL. I'll come back to this one once that one lands https://dart-review.googlesource.com/c/sdk/+/471061.
That CL has landed.
Related details
- Brian Wilkerson
- Samuel Rawlins
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |