[XS] Change in dart/sdk[main]: [vm, arm64e] Don't try to use icf with ld.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Jul 15, 2026, 1:35:28 PM (12 hours ago) Jul 15
to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Jul 15, 2026, 1:36:29 PM (12 hours ago) Jul 15
to Ryan Macnak, Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Aprelev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Jul 15, 2026, 1:37:02 PM (12 hours ago) Jul 15
to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 15, 2026, 1:37:16 PM (12 hours ago) Jul 15
to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org, vm-...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm, arm64e] Don't try to use icf with ld.
Fix gcc build.
TEST=local build
Change-Id: If7ac8acc87ad060cbb939bb2844c04b092423367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/524540
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Files:
- M build/config/compiler/BUILD.gn
- M runtime/bin/macho_loader.cc
Change size: XS
Delta: 2 files changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Aprelev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages