[S] Change in dart/sdk[stable]: [stable][DAS] Fixes dot-shorthands completion for enum constant creation

0 views
Skip to first unread message

Kallen Tu (Gerrit)

unread,
Dec 9, 2025, 6:23:33 PM12/9/25
to Samuel Rawlins, Leaf Petersen, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Leaf Petersen and Samuel Rawlins

Kallen Tu voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Leaf Petersen
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedChangelog
  • requirement satisfiedCherry-Pick
  • requirement is not satisfiedCherry-Pick-Review
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: stable
Gerrit-Change-Id: If4f6d8bd9e6060e2e24d7d84bc1d10e39b3001e3
Gerrit-Change-Number: 467242
Gerrit-PatchSet: 1
Gerrit-Owner: Kallen Tu <kall...@google.com>
Gerrit-Reviewer: Kallen Tu <kall...@google.com>
Gerrit-Reviewer: Leaf Petersen <le...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Leaf Petersen <le...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 23:23:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Dec 9, 2025, 6:24:41 PM12/9/25
to Kallen Tu, Leaf Petersen, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Kallen Tu and Leaf Petersen

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kallen Tu
  • Leaf Petersen
Submit Requirements:
    • requirement satisfiedChangelog
    • requirement satisfiedCherry-Pick
    • requirement is not satisfiedCherry-Pick-Review
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: stable
    Gerrit-Change-Id: If4f6d8bd9e6060e2e24d7d84bc1d10e39b3001e3
    Gerrit-Change-Number: 467242
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kallen Tu <kall...@google.com>
    Gerrit-Reviewer: Kallen Tu <kall...@google.com>
    Gerrit-Reviewer: Leaf Petersen <le...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Leaf Petersen <le...@google.com>
    Gerrit-Attention: Kallen Tu <kall...@google.com>
    Gerrit-Comment-Date: Tue, 09 Dec 2025 23:24:38 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Leaf Petersen (Gerrit)

    unread,
    Dec 10, 2025, 12:24:29 AM12/10/25
    to Kallen Tu, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Kallen Tu

    Leaf Petersen voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kallen Tu
    Submit Requirements:
      • requirement satisfiedChangelog
      • requirement satisfiedCherry-Pick
      • requirement satisfiedCherry-Pick-Review
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: stable
      Gerrit-Change-Id: If4f6d8bd9e6060e2e24d7d84bc1d10e39b3001e3
      Gerrit-Change-Number: 467242
      Gerrit-PatchSet: 1
      Gerrit-Owner: Kallen Tu <kall...@google.com>
      Gerrit-Reviewer: Kallen Tu <kall...@google.com>
      Gerrit-Reviewer: Leaf Petersen <le...@google.com>
      Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
      Gerrit-Attention: Kallen Tu <kall...@google.com>
      Gerrit-Comment-Date: Wed, 10 Dec 2025 05:24:27 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Kallen Tu (Gerrit)

      unread,
      Dec 10, 2025, 10:32:59 AM12/10/25
      to Leaf Petersen, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

      Kallen Tu voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedChangelog
      • requirement satisfiedCherry-Pick
      • requirement satisfiedCherry-Pick-Review
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: stable
      Gerrit-Change-Id: If4f6d8bd9e6060e2e24d7d84bc1d10e39b3001e3
      Gerrit-Change-Number: 467242
      Gerrit-PatchSet: 1
      Gerrit-Owner: Kallen Tu <kall...@google.com>
      Gerrit-Reviewer: Kallen Tu <kall...@google.com>
      Gerrit-Reviewer: Leaf Petersen <le...@google.com>
      Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
      Gerrit-Comment-Date: Wed, 10 Dec 2025 15:32:56 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Commit Queue (Gerrit)

      unread,
      Dec 10, 2025, 10:33:14 AM12/10/25
      to Kallen Tu, Leaf Petersen, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

      Commit Queue submitted the change

      Change information

      Commit message:
      [stable][DAS] Fixes dot-shorthands completion for enum constant creation

      Issue description: When trying to use code completion for an enum
      constant argument, dot shorthands don't show up.

      What is the fix: Add an extra missing case in the completion code for
      arguments.

      Why cherry-pick: Missing code completion functionality which could
      be useful for users, and is fairly low risk.

      Risk: Low, has been tested and the code change touches a very small
      surface area (only for code completion of arguments).

      Issue link(s): https://github.com/dart-lang/sdk/issues/62168
      Change-Id: If4f6d8bd9e6060e2e24d7d84bc1d10e39b3001e3
      Reviewed-by: Samuel Rawlins <sraw...@google.com>
      Commit-Queue: Kallen Tu <kall...@google.com>
      Reviewed-by: Leaf Petersen <le...@google.com>
      Files:
      • M CHANGELOG.md
      • M pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart
      • M pkg/analysis_server/test/services/completion/dart/declaration/enum_test.dart
      • M pkg/analysis_server/test/src/services/completion/dart/feature_computer_test.dart
      Change size: S
      Delta: 4 files changed, 38 insertions(+), 0 deletions(-)
      Branch: refs/heads/stable
      Submit Requirements:
      • requirement satisfiedCherry-Pick-Review: Code-Review+1 by Samuel Rawlins, Code-Review+1 by Leaf Petersen
      • requirement satisfiedCode-Review: +1 by Samuel Rawlins, +1 by Leaf Petersen
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: sdk
      Gerrit-Branch: stable
      Gerrit-Change-Id: If4f6d8bd9e6060e2e24d7d84bc1d10e39b3001e3
      Gerrit-Change-Number: 467242
      Gerrit-PatchSet: 2
      Gerrit-Owner: Kallen Tu <kall...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages