[S] Change in dart/sdk[stable]: [stable][DAS] Fixes dot-shorthands completion for enum constant creation
0 views
Skip to first unread message
Kallen Tu (Gerrit)
Dec 9, 2025, 6:23:33 PM12/9/25
to Samuel Rawlins, Leaf Petersen, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Leaf Petersen and Samuel Rawlins
Kallen Tu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Leaf Petersen
- Samuel Rawlins
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 9, 2025, 6:24:41 PM12/9/25
to Kallen Tu, Leaf Petersen, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Kallen Tu and Leaf Petersen
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kallen Tu
- Leaf Petersen
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leaf Petersen (Gerrit)
Dec 10, 2025, 12:24:29 AM12/10/25
to Kallen Tu, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Kallen Tu
Leaf Petersen voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kallen Tu
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
Dec 10, 2025, 10:32:59 AM12/10/25
to Leaf Petersen, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Kallen Tu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Changelog
Cherry-Pick
Cherry-Pick-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 10, 2025, 10:33:14 AM12/10/25
to Kallen Tu, Leaf Petersen, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[stable][DAS] Fixes dot-shorthands completion for enum constant creation
Issue description: When trying to use code completion for an enum
constant argument, dot shorthands don't show up.
What is the fix: Add an extra missing case in the completion code for
arguments.
Why cherry-pick: Missing code completion functionality which could
be useful for users, and is fairly low risk.
Risk: Low, has been tested and the code change touches a very small
surface area (only for code completion of arguments).
Issue link(s): https://github.com/dart-lang/sdk/issues/62168
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/466140
Change-Id: If4f6d8bd9e6060e2e24d7d84bc1d10e39b3001e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/467242
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Kallen Tu <kall...@google.com>
Reviewed-by: Leaf Petersen <le...@google.com>
Files:
- M CHANGELOG.md
- M pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart
- M pkg/analysis_server/test/services/completion/dart/declaration/enum_test.dart
- M pkg/analysis_server/test/src/services/completion/dart/feature_computer_test.dart
Change size: S
Delta: 4 files changed, 38 insertions(+), 0 deletions(-)
Branch: refs/heads/stable
Submit Requirements:
Cherry-Pick-Review: Code-Review+1 by Samuel Rawlins, Code-Review+1 by Leaf Petersen
Code-Review: +1 by Samuel Rawlins, +1 by Leaf Petersen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages