[M] Change in dart/sdk[main]: CQ. Give TypeParameterScope the enclosing library FeatureSet.
0 views
Skip to first unread message
Johnni Winther (Gerrit)
Feb 13, 2026, 4:36:58 AM (3 days ago) Feb 13
to Konstantin Shcheglov, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Feb 13, 2026, 11:22:48 AM (3 days ago) Feb 13
to Johnni Winther, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Feb 13, 2026, 11:23:20 AM (3 days ago) Feb 13
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
CQ. Give TypeParameterScope the enclosing library FeatureSet.
TypeParameterScope previously relied on
TypeParameterElement.isWildcardVariable to decide whether to exclude `_`
from scope. That check consults the element's library FeatureSet, which
can be unset, while we still building elements.
Plumb the current LibraryFragmentImpl through ScopeResolverVisitor and
ReferenceResolver, and pass the enclosing library FeatureSet into
TypeParameterScope so `_` is treated as a wildcard when the
wildcard_variables feature is enabled.
Change-Id: I4c7f9613ea8ef513e27bb08e453b8ae6615cb50a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480442
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
- M pkg/analyzer/lib/src/dart/element/scope.dart
- M pkg/analyzer/lib/src/generated/resolver.dart
- M pkg/analyzer/lib/src/summary2/ast_resolver.dart
- M pkg/analyzer/lib/src/summary2/library_builder.dart
- M pkg/analyzer/lib/src/summary2/reference_resolver.dart
Change size: M
Delta: 6 files changed, 112 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages