[L] Change in dart/sdk[main]: [DDS] Deprecate `getAvailableCachedCpuSamples` and `getCachedCpuSamples`
0 views
Skip to first unread message
Derek Xu (Gerrit)
Aug 7, 2025, 11:32:11 AM8/7/25
to Ben Konyi, Commit Queue, rev...@dartlang.org
Attention needed from Ben Konyi
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ben Konyi
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
Aug 7, 2025, 1:52:17 PM8/7/25
to Derek Xu, Commit Queue, rev...@dartlang.org
Attention needed from Derek Xu
Ben Konyi voted and added 2 comments![]( "Open in Gerrit")
Votes added by Ben Konyi
| Code-Review | +1 |
2 comments
Patchset-level comments
File pkg/dds/lib/dds.dart
Line 53, Patchset 4 (Parent):
List<String> cachedUserTags = const [],Ben Konyi . unresolved
I think we technically need to deprecate this parameter first since it's _technically_ still a public API on pub.
Related details
Attention is currently required from:
- Derek Xu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Derek Xu (Gerrit)
Aug 7, 2025, 3:09:25 PM8/7/25
to Ben Konyi, Commit Queue, rev...@dartlang.org
Attention needed from Ben Konyi
Derek Xu added 1 comment![]( "Open in Gerrit")
File pkg/dds/lib/dds.dart
Line 53, Patchset 4 (Parent):
List<String> cachedUserTags = const [],Ben Konyi . unresolved
I think we technically need to deprecate this parameter first since it's _technically_ still a public API on pub.
Derek Xu
Oh, true. Done. `DartDevelopmentService.cachedUserTags` is public too, so I've marked it as deprecated instead of deleting it. I've also updated `package:dds_service_extensions`. PTAL.
Related details
Attention is currently required from:
- Ben Konyi
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
Aug 8, 2025, 10:36:45 AM8/8/25
to Derek Xu, Commit Queue, rev...@dartlang.org
Attention needed from Derek Xu
Ben Konyi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ben Konyi
| Code-Review | +1 |
1 comment
File pkg/dds/lib/dds.dart
Line 53, Patchset 4 (Parent):
List<String> cachedUserTags = const [],Ben Konyi . resolved
Derek XuI think we technically need to deprecate this parameter first since it's _technically_ still a public API on pub.
Oh, true. Done. `DartDevelopmentService.cachedUserTags` is public too, so I've marked it as deprecated instead of deleting it. I've also updated `package:dds_service_extensions`. PTAL.
Attention is currently required from:
- Derek Xu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Derek Xu (Gerrit)
Aug 8, 2025, 10:42:36 AM8/8/25
to Ben Konyi, Commit Queue, rev...@dartlang.org
Derek Xu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages