[L] Change in dart/sdk[main]: analyzer: Move the mock 'dart:ui' library to the mock SDK
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Dec 12, 2025, 11:01:06 AM (9 days ago) Dec 12
to Samuel Rawlins, Brian Wilkerson, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 12, 2025, 11:52:22 AM (9 days ago) Dec 12
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 12, 2025, 1:14:08 PM (9 days ago) Dec 12
to Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Samuel Rawlins . unresolved
@sche...@google.com that test failure happens because the test is no longer _adding_ a dart:ui library (see https://github.com/dart-lang/sdk/blob/main/pkg/analyzer/test/dart/sdk/build_sdk_summary_test.dart#L36).
Do you have a suggestion on what to do with this test now? Should I change it to add a fictional 'dart:foo' or something?
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 19, 2025, 5:42:17 PM (2 days ago) Dec 19
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Samuel Rawlins . unresolved
@sche...@google.com that test failure happens because the test is no longer _adding_ a dart:ui library (see https://github.com/dart-lang/sdk/blob/main/pkg/analyzer/test/dart/sdk/build_sdk_summary_test.dart#L36).
Do you have a suggestion on what to do with this test now? Should I change it to add a fictional 'dart:foo' or something?
Konstantin Shcheglov
It is easy to update the test to make it pass:
```
expect(dartUi.getClass('Color'), isNotNull);
expect(dartUi.getEnum('FontStyle'), isNotNull);
```
However maybe adding `dart:ui` unconditionally is not correct. It is not present in Dart SDK by default, and is added like the test does: via `sky_engine`. So, I think we would lose some test coverage with this change.
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages