[M] Change in dart/sdk[main]: analyzer: Remove unused EmbedderYamlLocator constructor; simplify
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Jan 21, 2026, 12:11:42 PM (12 hours ago) Jan 21
to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Jan 21, 2026, 12:13:56 PM (12 hours ago) Jan 21
to Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Jan 21, 2026, 12:14:14 PM (12 hours ago) Jan 21
to Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
analyzer: Remove unused EmbedderYamlLocator constructor; simplify
`EmbedderYamlLocator()` was only used by dartdoc; that usage was removed
recently, and dartdoc rolled into the SDK. After that is removed, we no longer need `_processPackageMap` or `_processPackage`.
Also the `addEmbedderYaml` and `refresh` methods were unused.
The `test_invalid` test only made sense with the unnamed constructor.
Change-Id: I395d76bebd09df2b21d5e161ce4364ab79ab56b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/472600
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analyzer/lib/src/context/builder.dart
- M pkg/analyzer/test/src/context/builder_test.dart
- M pkg/analyzer/test/src/dart/sdk/sdk_test.dart
Change size: M
Delta: 3 files changed, 33 insertions(+), 94 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages