[M] Change in dart/sdk[main]: [DAS] Fixes dot shorthand completion for if case and `&&`/`||` operators

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Jan 9, 2026, 7:38:36 AM (2 days ago) Jan 9
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Fixes dot shorthand completion for if case and `&&`/`||` operators
Change-Id: If8e161d37caf9e8c561cb28e42ae2cbe4ac7fada

Change information

Files:
  • M pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart
  • M pkg/analysis_server/test/services/completion/dart/location/dot_shorthand_property_access_test.dart
  • M pkg/analysis_server/test/src/services/completion/dart/feature_computer_test.dart
Change size: M
Delta: 3 files changed, 93 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If8e161d37caf9e8c561cb28e42ae2cbe4ac7fada
Gerrit-Change-Number: 471780
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Jan 9, 2026, 6:07:53 PM (2 days ago) Jan 9
to Felipe Morschel, Keerti Parthasarathy, Kallen Tu, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Keerti Parthasarathy

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
  • Keerti Parthasarathy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If8e161d37caf9e8c561cb28e42ae2cbe4ac7fada
Gerrit-Change-Number: 471780
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Kallen Tu <kall...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 23:07:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Felipe Morschel (Gerrit)

unread,
Jan 9, 2026, 8:09:05 PM (2 days ago) Jan 9
to Commit Queue, Samuel Rawlins, Keerti Parthasarathy, Kallen Tu, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy and Samuel Rawlins

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Felipe Morschel . resolved

Thanks for the bots! I'd missed those logical and/or tests. They only needed to be sorted but I've added a new one to make sure we suggest the enum properties too.

Open in Gerrit

Related details

Attention is currently required from:
  • Keerti Parthasarathy
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If8e161d37caf9e8c561cb28e42ae2cbe4ac7fada
Gerrit-Change-Number: 471780
Gerrit-PatchSet: 2
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Kallen Tu <kall...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Sat, 10 Jan 2026 01:09:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages