[M] Change in dart/sdk[main]: [dartdev][migrate] Allow multiple target packages.

0 views

Skip to first unread message

Kallen Tu (Gerrit)

unread,

3:46 PM (3 hours ago) 3:46 PM

to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org

Attention needed from Brian Wilkerson

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

4:07 PM (3 hours ago) 4:07 PM

to Kallen Tu, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org

Attention needed from Kallen Tu

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review

1 comment

File pkg/dartdev/lib/src/commands/migrate.dart

Line 249, Patchset 7 (Latest): usageException(

Brian Wilkerson . resolved

Consider checking all of the directories before issuing the error. That way if there's more than one invalid directory the user can fix them all on the next invocation rather than having to discover them one-by-one.

Open in Gerrit

Related details

Attention is currently required from:

Kallen Tu

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages