[M] Change in dart/sdk[main]: [dtd_impl] Update PID file logic to use dart_data_home logic

0 views
Skip to first unread message

Ben Konyi (Gerrit)

unread,
Mar 12, 2026, 4:37:18 PMMar 12
to Jaime Wren, Jake Macdonald, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Jaime Wren

Ben Konyi voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jaime Wren
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I37d3ccc911041e56b5e3eeabc2aeaf4cde1785f8
Gerrit-Change-Number: 487543
Gerrit-PatchSet: 1
Gerrit-Owner: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jaime Wren <jw...@google.com>
Gerrit-CC: Jake Macdonald <jak...@google.com>
Gerrit-CC: Slava Egorov <veg...@google.com>
Gerrit-Attention: Jaime Wren <jw...@google.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 20:37:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Slava Egorov (Gerrit)

unread,
Mar 13, 2026, 5:37:28 AMMar 13
to Jaime Wren, Ben Konyi, Jake Macdonald, Commit Queue, rev...@dartlang.org
Attention needed from Jaime Wren

Slava Egorov added 1 comment

File pkg/dtd_impl/lib/src/dart_tooling_daemon.dart
Line 502, Patchset 1 (Latest): for (final entry in pidFiles.entries) {
Slava Egorov . unresolved

nit: `.values`?

Open in Gerrit

Related details

Attention is currently required from:
  • Jaime Wren
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I37d3ccc911041e56b5e3eeabc2aeaf4cde1785f8
Gerrit-Change-Number: 487543
Gerrit-PatchSet: 1
Gerrit-Owner: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jaime Wren <jw...@google.com>
Gerrit-CC: Jake Macdonald <jak...@google.com>
Gerrit-CC: Slava Egorov <veg...@google.com>
Gerrit-Attention: Jaime Wren <jw...@google.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 09:37:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Jaime Wren (Gerrit)

unread,
Mar 17, 2026, 12:20:48 PMMar 17
to Ben Konyi, Jake Macdonald, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov

Jaime Wren added 1 comment

File pkg/dtd_impl/lib/src/dart_tooling_daemon.dart
Line 502, Patchset 1: for (final entry in pidFiles.entries) {
Slava Egorov . resolved

nit: `.values`?

Jaime Wren

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I37d3ccc911041e56b5e3eeabc2aeaf4cde1785f8
Gerrit-Change-Number: 487543
Gerrit-PatchSet: 2
Gerrit-Owner: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jaime Wren <jw...@google.com>
Gerrit-CC: Jake Macdonald <jak...@google.com>
Gerrit-CC: Slava Egorov <veg...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Tue, 17 Mar 2026 16:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Slava Egorov <veg...@google.com>
satisfied_requirement
open
diffy

Jake Macdonald (Gerrit)

unread,
Mar 17, 2026, 12:34:46 PMMar 17
to Jaime Wren, Ben Konyi, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Jaime Wren and Slava Egorov

Jake Macdonald voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jaime Wren
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I37d3ccc911041e56b5e3eeabc2aeaf4cde1785f8
Gerrit-Change-Number: 487543
Gerrit-PatchSet: 2
Gerrit-Owner: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Jake Macdonald <jak...@google.com>
Gerrit-CC: Slava Egorov <veg...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Attention: Jaime Wren <jw...@google.com>
Gerrit-Comment-Date: Tue, 17 Mar 2026 16:34:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jaime Wren (Gerrit)

unread,
Mar 17, 2026, 2:19:05 PMMar 17
to Jake Macdonald, Ben Konyi, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov

Jaime Wren voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I37d3ccc911041e56b5e3eeabc2aeaf4cde1785f8
Gerrit-Change-Number: 487543
Gerrit-PatchSet: 2
Gerrit-Owner: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Jake Macdonald <jak...@google.com>
Gerrit-CC: Slava Egorov <veg...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Tue, 17 Mar 2026 18:19:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Mar 17, 2026, 2:19:14 PMMar 17
to Jaime Wren, Jake Macdonald, Ben Konyi, Slava Egorov, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[dtd_impl] Update  PID file  logic to use dart_data_home logic

See https://dart-review.googlesource.com/c/sdk/+/487000
Change-Id: I37d3ccc911041e56b5e3eeabc2aeaf4cde1785f8
Reviewed-by: Ben Konyi <bko...@google.com>
Reviewed-by: Jake Macdonald <jak...@google.com>
Commit-Queue: Jaime Wren <jw...@google.com>
Files:
  • M pkg/dtd_impl/lib/src/dart_tooling_daemon.dart
  • M pkg/dtd_impl/test/pid_file_discovery_test.dart
Change size: M
Delta: 2 files changed, 25 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jake Macdonald, +1 by Ben Konyi
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I37d3ccc911041e56b5e3eeabc2aeaf4cde1785f8
Gerrit-Change-Number: 487543
Gerrit-PatchSet: 3
Gerrit-Owner: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Jake Macdonald <jak...@google.com>
Gerrit-CC: Slava Egorov <veg...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages