[M] Change in dart/sdk[main]: [dtd_impl] Update PID file logic to use dart_data_home logic
0 views
Skip to first unread message
Ben Konyi (Gerrit)
Mar 12, 2026, 4:37:18 PMMar 12
to Jaime Wren, Jake Macdonald, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Jaime Wren
Ben Konyi voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jaime Wren
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
Mar 13, 2026, 5:37:28 AMMar 13
to Jaime Wren, Ben Konyi, Jake Macdonald, Commit Queue, rev...@dartlang.org
Attention needed from Jaime Wren
Slava Egorov added 1 comment![]( "Open in Gerrit")
File pkg/dtd_impl/lib/src/dart_tooling_daemon.dart
Line 502, Patchset 1 (Latest):
for (final entry in pidFiles.entries) {Slava Egorov . unresolved
nit: `.values`?
Related details
Attention is currently required from:
- Jaime Wren
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jaime Wren (Gerrit)
Mar 17, 2026, 12:20:48 PMMar 17
to Ben Konyi, Jake Macdonald, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov
Jaime Wren added 1 comment![]( "Open in Gerrit")
File pkg/dtd_impl/lib/src/dart_tooling_daemon.dart
Line 502, Patchset 1:
for (final entry in pidFiles.entries) {Slava Egorov . resolved
Jaime Wrennit: `.values`?
Done
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Macdonald (Gerrit)
Mar 17, 2026, 12:34:46 PMMar 17
to Jaime Wren, Ben Konyi, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Jaime Wren and Slava Egorov
Jake Macdonald voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jaime Wren
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jaime Wren (Gerrit)
Mar 17, 2026, 2:19:05 PMMar 17
to Jake Macdonald, Ben Konyi, Slava Egorov, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov
Jaime Wren voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 17, 2026, 2:19:14 PMMar 17
to Jaime Wren, Jake Macdonald, Ben Konyi, Slava Egorov, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[dtd_impl] Update PID file logic to use dart_data_home logic
See https://dart-review.googlesource.com/c/sdk/+/487000
Change-Id: I37d3ccc911041e56b5e3eeabc2aeaf4cde1785f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487543
Reviewed-by: Ben Konyi <bko...@google.com>
Reviewed-by: Jake Macdonald <jak...@google.com>
Commit-Queue: Jaime Wren <jw...@google.com>
Files:
- M pkg/dtd_impl/lib/src/dart_tooling_daemon.dart
- M pkg/dtd_impl/test/pid_file_discovery_test.dart
Change size: M
Delta: 2 files changed, 25 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jake Macdonald, +1 by Ben Konyi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages