[XS] Change in dart/sdk[main]: [frontend_server_client] Copy changes from github

0 views
Skip to first unread message

Brian Quinlan (Gerrit)

unread,
Jun 23, 2026, 3:42:04 PM (10 hours ago) Jun 23
to Nate Biggs, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Nate Biggs

Brian Quinlan added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Brian Quinlan . resolved

Jessy is OOO. I think that sync with the canonical repo is currently done manually (see https://github.com/dart-lang/sdk/commit/a89b2d6e53900d779c97e7246b9fb30f1ffbb06d). I need this to unblock the deps roll.

Open in Gerrit

Related details

Attention is currently required from:
  • Nate Biggs
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9d851e1d489487ddac99f1bc28f73c1d63e337d
Gerrit-Change-Number: 516360
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Quinlan <bqui...@google.com>
Gerrit-Reviewer: Brian Quinlan <bqui...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 19:42:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Biggs (Gerrit)

unread,
Jun 23, 2026, 3:43:06 PM (10 hours ago) Jun 23
to Brian Quinlan, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Brian Quinlan

Nate Biggs voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Quinlan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9d851e1d489487ddac99f1bc28f73c1d63e337d
Gerrit-Change-Number: 516360
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Quinlan <bqui...@google.com>
Gerrit-Reviewer: Brian Quinlan <bqui...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Brian Quinlan <bqui...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 19:43:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Brian Quinlan (Gerrit)

unread,
Jun 23, 2026, 3:44:07 PM (10 hours ago) Jun 23
to Nate Biggs, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org

Brian Quinlan voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9d851e1d489487ddac99f1bc28f73c1d63e337d
Gerrit-Change-Number: 516360
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Quinlan <bqui...@google.com>
Gerrit-Reviewer: Brian Quinlan <bqui...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 19:44:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 23, 2026, 3:44:21 PM (10 hours ago) Jun 23
to Brian Quinlan, Nate Biggs, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[frontend_server_client] Copy changes from github

    Copy into pkg/frontend_server_client.

    * https://github.com/dart-lang/webdev/commit/86e55394b0186d3cc6052d1fdf4e96a4ad873017

    Selectively revert incompatible changes to the pubspec.yaml files.
Change-Id: Id9d851e1d489487ddac99f1bc28f73c1d63e337d
Commit-Queue: Brian Quinlan <bqui...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Files:
  • M pkg/frontend_server_client/CHANGELOG.md
  • M pkg/frontend_server_client/pubspec.yaml
Change size: XS
Delta: 2 files changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Biggs
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id9d851e1d489487ddac99f1bc28f73c1d63e337d
Gerrit-Change-Number: 516360
Gerrit-PatchSet: 2
Gerrit-Owner: Brian Quinlan <bqui...@google.com>
Gerrit-Reviewer: Brian Quinlan <bqui...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages