[S] Change in dart/sdk[main]: [vm, arm64] Don't generate push sp.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
3:36 PM (3 hours ago) 3:36 PM
to Alexander Markov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
Ryan Macnak voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
5:09 PM (2 hours ago) 5:09 PM
to Ryan Macnak, Alexander Markov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Markov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Markov
| Code-Review | +1 |
1 comment
File runtime/vm/compiler/assembler/assembler_arm64.cc
Line 1693, Patchset 3 (Latest):
__ mov(CALLEE_SAVED_TEMP, SP);Alexander Markov . unresolved
Should we also set `CSP` to an aligned value around `SP` before the call, e.g. like in `StubCodeCompiler::GenerateEnterSafepointStub`?
Related details
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
5:40 PM (1 hour ago) 5:40 PM
to Alexander Markov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ryan Macnak
| Commit-Queue | +2 |
1 comment
File runtime/vm/compiler/assembler/assembler_arm64.cc
Line 1693, Patchset 3 (Latest):
__ mov(CALLEE_SAVED_TEMP, SP);Alexander Markov . resolved
Should we also set `CSP` to an aligned value around `SP` before the call, e.g. like in `StubCodeCompiler::GenerateEnterSafepointStub`?
Ryan Macnak
CSP is currently at an aligned value somewhere near the stack limit, so that signal handlers can run in the middle of Dart code. We're not passing any argument by stack here and I expect this msan function requires very little stack (just zeroing some TLS), so I don't see a need to update CSP here.
Actually, we should be able to skip this for leaf runtime functions more generally.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
5:49 PM (1 hour ago) 5:49 PM
to Ryan Macnak, Alexander Markov, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm, arm64] Don't generate push sp.
TEST=debug msan
Bug: b/542394589
Bug: https://github.com/dart-lang/sdk/issues/39083
Change-Id: I98119be7af408dda52bed4cec60b3b9aac5adbf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/531860
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
Files:
- M runtime/vm/compiler/assembler/assembler_arm64.cc
Change size: S
Delta: 1 file changed, 7 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Markov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages