[M] Change in dart/sdk[main]: Flag redundant null argument values in avoid_redundant_argument_values

0 views
Skip to first unread message

Kevin Moore (Gerrit)

unread,
Mar 27, 2026, 5:13:58 PM (3 days ago) Mar 27
to Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Phil Quitslund

Kevin Moore voted and added 1 comment

Votes added by Kevin Moore

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kevin Moore . resolved

I'll get ahead of the flutter bits before this lands!

Open in Gerrit

Related details

Attention is currently required from:
  • Phil Quitslund
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3a6ad733c3820d3bf234bd6e5c0e13eaa9773729
Gerrit-Change-Number: 491341
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Attention: Phil Quitslund <pquit...@google.com>
Gerrit-Comment-Date: Fri, 27 Mar 2026 21:13:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Kevin Moore (Gerrit)

unread,
Mar 28, 2026, 12:40:42 AM (3 days ago) Mar 28
to Commit Queue, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Phil Quitslund

Kevin Moore voted and added 1 comment

Votes added by Kevin Moore

Auto-Submit+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Phil Quitslund
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3a6ad733c3820d3bf234bd6e5c0e13eaa9773729
Gerrit-Change-Number: 491341
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Attention: Phil Quitslund <pquit...@google.com>
Gerrit-Comment-Date: Sat, 28 Mar 2026 04:40:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
9:54 PM (2 hours ago) 9:54 PM
to Kevin Moore, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Kevin Moore

Samuel Rawlins added 1 comment

File pkg/analyzer/lib/src/dart/analysis/driver.dart
Line 111, Patchset 3 (Latest): static const int DATA_VERSION = 613;
Samuel Rawlins . unresolved

I don't believe this change is needed.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Kevin Moore
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3a6ad733c3820d3bf234bd6e5c0e13eaa9773729
Gerrit-Change-Number: 491341
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Kevin Moore <kev...@google.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 01:54:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Kevin Moore (Gerrit)

unread,
10:11 PM (1 hour ago) 10:11 PM
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins

Kevin Moore added 1 comment

File pkg/analyzer/lib/src/dart/analysis/driver.dart
Line 111, Patchset 3 (Latest): static const int DATA_VERSION = 613;
Samuel Rawlins . unresolved

I don't believe this change is needed.

Kevin Moore

I was getting really weird behavior locally. Like it wouldn't fix the thing UNLESS the file was dirty. :shrug:

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3a6ad733c3820d3bf234bd6e5c0e13eaa9773729
Gerrit-Change-Number: 491341
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 02:11:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Samuel Rawlins <sraw...@google.com>
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages