[S] Change in dart/sdk[main]: DeCo. Change to 'class EnumBody implements AstNode', not 'ClassBody'.
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Oct 29, 2025, 6:32:59 PM (3 days ago) Oct 29
to Konstantin Shcheglov, Brian Wilkerson, Paul Berry, Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Brian Wilkerson . resolved
I don't really have the context for this change, but I'm ok with getting caught up later.
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
Oct 29, 2025, 6:50:47 PM (3 days ago) Oct 29
to Konstantin Shcheglov, Brian Wilkerson, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Kallen Tu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Brian Wilkerson . unresolved
I don't really have the context for this change, but I'm ok with getting caught up later.
Kallen Tu
If you could explain with this comment thread or the commit message, @sche...@google.com, I'd love to know the context behind this change.
Konstantin Shcheglov (Gerrit)
Oct 30, 2025, 1:50:19 PM (2 days ago) Oct 30
to Brian Wilkerson, Paul Berry, Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Oct 30, 2025, 1:50:33 PM (2 days ago) Oct 30
to Konstantin Shcheglov, Brian Wilkerson, Paul Berry, Kallen Tu, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
DeCo. Change to 'class EnumBody implements AstNode', not 'ClassBody'.
Paul and I discussed offline in the context of https://dart-review.googlesource.com/c/sdk/+/457161 and decided that `EnumBody` is different enough that it does not fit into the `ClassBody` hierarchy. For example `ClassDeclaration` has `body`, but it cannot have `EnumBody`.
Change-Id: Icccbf87883cdfa42b0dd026a5ddc9a40d644a5ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458440
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analyzer/api.txt
- M pkg/analyzer/lib/dart/ast/visitor.g.dart
- M pkg/analyzer/lib/src/dart/ast/ast.dart
Change size: S
Delta: 3 files changed, 5 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
Oct 30, 2025, 2:03:31 PM (2 days ago) Oct 30
to Konstantin Shcheglov, Commit Queue, Brian Wilkerson, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Kallen Tu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kallen TuI don't really have the context for this change, but I'm ok with getting caught up later.
If you could explain with this comment thread or the commit message, @sche...@google.com, I'd love to know the context behind this change.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages