[M] Change in dart/sdk[main]: Issue 56118. Add DartObject.toTypeValueNotExtensionTypeErased() as ex...

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Apr 17, 2026, 1:48:35 PM (5 days ago) Apr 17
to Srujan Gaddam, Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Paul Berry

Konstantin Shcheglov voted and added 1 comment

Votes added by Konstantin Shcheglov

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2:
Johnni Winther . unresolved

@sche...@google.com could we land this as experimental? This would unblock Srujan and give us time to design the right long term solution.

Konstantin Shcheglov

OK, I turned `toTypeValueNotExtensionTypeErased` into experimental.

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
  • Paul Berry
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iab31aec4737267e03fff7435bd92c3226c9f1744
Gerrit-Change-Number: 488060
Gerrit-PatchSet: 5
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-CC: Srujan Gaddam <sru...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Fri, 17 Apr 2026 17:48:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Johnni Winther <johnni...@google.com>
unsatisfied_requirement
open
diffy

Srujan Gaddam (Gerrit)

unread,
Apr 17, 2026, 3:16:19 PM (5 days ago) Apr 17
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry

Srujan Gaddam added 2 comments

Patchset-level comments
Johnni Winther . unresolved

@sche...@google.com could we land this as experimental? This would unblock Srujan and give us time to design the right long term solution.

Konstantin Shcheglov

OK, I turned `toTypeValueNotExtensionTypeErased` into experimental.

Srujan Gaddam

Thank you both! 🙏

File pkg/analyzer/lib/dart/constant/value.dart
Line 83, Patchset 2: DartType? get type;
Srujan Gaddam . unresolved

FYI as I'm working through the Angular compiler code, we may also need `typeNotErased`. I *think* `typeNotErased` is more a matter of convenience than a necessity compared to `toTypeValueNotErased` but TBD.

Srujan Gaddam

There are a few spots where I had to use `typeNotErased` which I *think* we can avoid, but I couldn't quite figure it out.

Here is one example, where we potentially walk up a type hierarchy using `superclass` to then get the type argument:
https://critique.corp.google.com/cl/900764996/depot/google3/third_party/dart_src/angular/angular_compiler/lib/src/angular_compiler/analyzer/common.dart?left=r25&right=s1#178R . I don't know of a way to walk the hierarchy of a DartObject instead like that.

The prototype is here: cl/900764996.

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
  • Konstantin Shcheglov
  • Paul Berry
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iab31aec4737267e03fff7435bd92c3226c9f1744
Gerrit-Change-Number: 488060
Gerrit-PatchSet: 5
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-CC: Srujan Gaddam <sru...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Fri, 17 Apr 2026 19:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Konstantin Shcheglov <sche...@google.com>
Comment-In-Reply-To: Johnni Winther <johnni...@google.com>
Comment-In-Reply-To: Srujan Gaddam <sru...@google.com>
unsatisfied_requirement
open
diffy

Srujan Gaddam (Gerrit)

unread,
Apr 20, 2026, 4:19:25 PM (2 days ago) Apr 20
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry

Srujan Gaddam added 1 comment

File pkg/analyzer/lib/dart/constant/value.dart
Line 83, Patchset 2: DartType? get type;
Srujan Gaddam . resolved

FYI as I'm working through the Angular compiler code, we may also need `typeNotErased`. I *think* `typeNotErased` is more a matter of convenience than a necessity compared to `toTypeValueNotErased` but TBD.

Srujan Gaddam

There are a few spots where I had to use `typeNotErased` which I *think* we can avoid, but I couldn't quite figure it out.

Here is one example, where we potentially walk up a type hierarchy using `superclass` to then get the type argument:
https://critique.corp.google.com/cl/900764996/depot/google3/third_party/dart_src/angular/angular_compiler/lib/src/angular_compiler/analyzer/common.dart?left=r25&right=s1#178R . I don't know of a way to walk the hierarchy of a DartObject instead like that.

The prototype is here: cl/900764996.

Srujan Gaddam

It looks like Konstantin added a patch set for this member, so LGTM. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
  • Konstantin Shcheglov
  • Paul Berry
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Iab31aec4737267e03fff7435bd92c3226c9f1744
Gerrit-Change-Number: 488060
Gerrit-PatchSet: 7
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-CC: Srujan Gaddam <sru...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 20:19:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Srujan Gaddam <sru...@google.com>
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Apr 21, 2026, 3:45:51 AM (yesterday) Apr 21
to Konstantin Shcheglov, Srujan Gaddam, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry

Johnni Winther voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
  • Paul Berry
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iab31aec4737267e03fff7435bd92c3226c9f1744
    Gerrit-Change-Number: 488060
    Gerrit-PatchSet: 7
    Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-CC: Srujan Gaddam <sru...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 07:45:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Berry (Gerrit)

    unread,
    Apr 21, 2026, 10:27:24 AM (yesterday) Apr 21
    to Konstantin Shcheglov, Johnni Winther, Srujan Gaddam, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Konstantin Shcheglov

    Paul Berry voted and added 1 comment

    Votes added by Paul Berry

    Code-Review+1

    1 comment

    Patchset-level comments
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Konstantin Shcheglov
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iab31aec4737267e03fff7435bd92c3226c9f1744
    Gerrit-Change-Number: 488060
    Gerrit-PatchSet: 7
    Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-CC: Srujan Gaddam <sru...@google.com>
    Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 14:27:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Brian Wilkerson (Gerrit)

    unread,
    Apr 21, 2026, 3:40:56 PM (20 hours ago) Apr 21
    to Konstantin Shcheglov, Brian Wilkerson, Paul Berry, Johnni Winther, Srujan Gaddam, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Konstantin Shcheglov

    Brian Wilkerson voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Konstantin Shcheglov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Iab31aec4737267e03fff7435bd92c3226c9f1744
    Gerrit-Change-Number: 488060
    Gerrit-PatchSet: 7
    Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-CC: Srujan Gaddam <sru...@google.com>
    Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 19:40:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages