[XL] Change in dart/sdk[main]: linter: Rename "markdown" APIs to "markup"

0 views

Skip to first unread message

Brian Wilkerson (Gerrit)

unread,

Jun 23, 2026, 4:18:21 PM (2 days ago) Jun 23

to Samuel Rawlins, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, SLSA Policy Verification Service, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Samuel Rawlins

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Brian Wilkerson . resolved

Spot checked.

Open in Gerrit

Related details

Attention is currently required from:

Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

Jun 23, 2026, 6:08:31 PM (2 days ago) Jun 23

to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, SLSA Policy Verification Service, dart-analys...@google.com, rev...@dartlang.org

Samuel Rawlins voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Jun 23, 2026, 6:08:47 PM (2 days ago) Jun 23

to Samuel Rawlins, Brian Wilkerson, SLSA Policy Verification Service, dart-analys...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

linter: Rename "markdown" APIs to "markup"

"Markdown" is a specific markup language which is unrelated to the syntax
supported by these APIs.

Change-Id: Iae4dbf41844b9873d725f8dd431235fbf71d5e7c

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/516381

Reviewed-by: Brian Wilkerson <brianwi...@google.com>

SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Commit-Queue: Samuel Rawlins <sraw...@google.com>

Files:

M pkg/linter/test/rule_test_support.dart
M pkg/linter/test/rules/always_declare_return_types_test.dart
M pkg/linter/test/rules/always_put_control_body_on_new_line_test.dart
M pkg/linter/test/rules/always_put_required_named_parameters_first_test.dart
M pkg/linter/test/rules/always_specify_types_test.dart
M pkg/linter/test/rules/always_use_package_imports_test.dart
M pkg/linter/test/rules/annotate_overrides_test.dart
M pkg/linter/test/rules/annotate_redeclares_test.dart
M pkg/linter/test/rules/async_return_with_no_await_test.dart
M pkg/linter/test/rules/avoid_annotating_with_dynamic_test.dart
M pkg/linter/test/rules/avoid_bool_literals_in_conditional_expressions_test.dart
M pkg/linter/test/rules/avoid_catches_without_on_clauses_test.dart
M pkg/linter/test/rules/avoid_catching_errors_test.dart
M pkg/linter/test/rules/avoid_classes_with_only_static_members_test.dart
M pkg/linter/test/rules/avoid_double_and_int_checks_test.dart
M pkg/linter/test/rules/avoid_dynamic_calls_test.dart
M pkg/linter/test/rules/avoid_empty_else_test.dart
M pkg/linter/test/rules/avoid_equals_and_hash_code_on_mutable_classes_test.dart
M pkg/linter/test/rules/avoid_escaping_inner_quotes_test.dart
M pkg/linter/test/rules/avoid_field_initializers_in_const_classes_test.dart
M pkg/linter/test/rules/avoid_field_initializers_in_non_const_classes_test.dart
M pkg/linter/test/rules/avoid_final_parameters_test.dart
M pkg/linter/test/rules/avoid_function_literals_in_foreach_calls_test.dart
M pkg/linter/test/rules/avoid_futureor_void_test.dart
M pkg/linter/test/rules/avoid_implementing_value_types_test.dart
M pkg/linter/test/rules/avoid_init_to_null_test.dart
M pkg/linter/test/rules/avoid_js_rounded_ints_test.dart
M pkg/linter/test/rules/avoid_multiple_declarations_per_line_test.dart
M pkg/linter/test/rules/avoid_positional_boolean_parameters_test.dart
M pkg/linter/test/rules/avoid_print_test.dart
M pkg/linter/test/rules/avoid_private_typedef_functions_test.dart
M pkg/linter/test/rules/avoid_redundant_argument_values_test.dart
M pkg/linter/test/rules/avoid_relative_lib_imports_test.dart
M pkg/linter/test/rules/avoid_renaming_method_parameters_test.dart
M pkg/linter/test/rules/avoid_return_types_on_setters_test.dart
M pkg/linter/test/rules/avoid_returning_null_for_void_test.dart
M pkg/linter/test/rules/avoid_returning_this_test.dart
M pkg/linter/test/rules/avoid_setters_without_getters_test.dart
M pkg/linter/test/rules/avoid_shadowing_type_parameters_test.dart
M pkg/linter/test/rules/avoid_single_cascade_in_expression_statements_test.dart
M pkg/linter/test/rules/avoid_slow_async_io_test.dart
M pkg/linter/test/rules/avoid_type_to_string_test.dart
M pkg/linter/test/rules/avoid_types_as_parameter_names_test.dart
M pkg/linter/test/rules/avoid_types_on_closure_parameters_test.dart
M pkg/linter/test/rules/avoid_unnecessary_containers_test.dart
M pkg/linter/test/rules/avoid_unused_constructor_parameters_test.dart
M pkg/linter/test/rules/avoid_void_async_test.dart
M pkg/linter/test/rules/avoid_web_libraries_in_flutter_test.dart
M pkg/linter/test/rules/await_only_futures_test.dart
M pkg/linter/test/rules/camel_case_extensions_test.dart
M pkg/linter/test/rules/camel_case_types_test.dart
M pkg/linter/test/rules/cancel_subscriptions_test.dart
M pkg/linter/test/rules/cascade_invocations_test.dart
M pkg/linter/test/rules/cast_nullable_to_non_nullable_test.dart
M pkg/linter/test/rules/close_sinks_test.dart
M pkg/linter/test/rules/collection_methods_unrelated_type_test.dart
M pkg/linter/test/rules/combinators_ordering_test.dart
M pkg/linter/test/rules/comment_references_test.dart
M pkg/linter/test/rules/constant_identifier_names_test.dart
M pkg/linter/test/rules/control_flow_in_finally_test.dart
M pkg/linter/test/rules/curly_braces_in_flow_control_structures_test.dart
M pkg/linter/test/rules/dangling_library_doc_comments_test.dart
M pkg/linter/test/rules/depend_on_referenced_packages_test.dart
M pkg/linter/test/rules/deprecated_consistency_test.dart
M pkg/linter/test/rules/deprecated_member_use_from_same_package_test.dart
M pkg/linter/test/rules/diagnostic_describe_all_properties_test.dart
M pkg/linter/test/rules/directives_ordering_test.dart
M pkg/linter/test/rules/discarded_futures_test.dart
M pkg/linter/test/rules/do_not_use_environment_test.dart
M pkg/linter/test/rules/document_ignores_test.dart
M pkg/linter/test/rules/empty_catches_test.dart
M pkg/linter/test/rules/empty_constructor_bodies_test.dart
M pkg/linter/test/rules/empty_container_bodies_test.dart
M pkg/linter/test/rules/empty_statements_test.dart
M pkg/linter/test/rules/eol_at_end_of_file_test.dart
M pkg/linter/test/rules/erase_dart_type_extension_types_test.dart
M pkg/linter/test/rules/exhaustive_cases_test.dart
M pkg/linter/test/rules/file_names_test.dart
M pkg/linter/test/rules/hash_and_equals_test.dart
M pkg/linter/test/rules/implicit_call_tearoffs_test.dart
M pkg/linter/test/rules/implicit_reopen_test.dart
M pkg/linter/test/rules/initialize_in_field_declaration_test.dart
M pkg/linter/test/rules/invalid_case_patterns_test.dart
M pkg/linter/test/rules/invalid_runtime_check_with_js_interop_types_test.dart
M pkg/linter/test/rules/join_return_with_assignment_test.dart
M pkg/linter/test/rules/leading_newlines_in_multiline_strings_test.dart
M pkg/linter/test/rules/library_annotations_test.dart
M pkg/linter/test/rules/library_names_test.dart
M pkg/linter/test/rules/library_prefixes_test.dart
M pkg/linter/test/rules/library_private_types_in_public_api_test.dart
M pkg/linter/test/rules/lines_longer_than_80_chars_test.dart
M pkg/linter/test/rules/literal_only_boolean_expressions_test.dart
M pkg/linter/test/rules/matching_super_parameters_test.dart
M pkg/linter/test/rules/missing_code_block_language_in_doc_comment_test.dart
M pkg/linter/test/rules/missing_whitespace_between_adjacent_strings_test.dart
M pkg/linter/test/rules/no_adjacent_strings_in_list_test.dart
M pkg/linter/test/rules/no_default_cases_test.dart
M pkg/linter/test/rules/no_duplicate_case_values_test.dart
M pkg/linter/test/rules/no_dynamic_casts_test.dart
M pkg/linter/test/rules/no_leading_underscores_for_library_prefixes_test.dart
M pkg/linter/test/rules/no_leading_underscores_for_local_identifiers_test.dart
M pkg/linter/test/rules/no_literal_bool_comparisons_test.dart
M pkg/linter/test/rules/no_logic_in_create_state_test.dart
M pkg/linter/test/rules/no_raw_types_test.dart
M pkg/linter/test/rules/no_runtimeType_toString_test.dart
M pkg/linter/test/rules/no_self_assignments_test.dart
M pkg/linter/test/rules/no_wildcard_variable_uses_test.dart
M pkg/linter/test/rules/non_constant_identifier_names_test.dart
M pkg/linter/test/rules/noop_primitive_operations_test.dart
M pkg/linter/test/rules/null_check_on_nullable_type_parameter_test.dart
M pkg/linter/test/rules/null_closures_test.dart
M pkg/linter/test/rules/omit_local_variable_types_test.dart
M pkg/linter/test/rules/omit_obvious_local_variable_types_test.dart
M pkg/linter/test/rules/omit_obvious_property_types_test.dart
M pkg/linter/test/rules/one_member_abstracts_test.dart
M pkg/linter/test/rules/only_throw_errors_test.dart
M pkg/linter/test/rules/overridden_fields_test.dart
M pkg/linter/test/rules/package_prefixed_library_names_test.dart
M pkg/linter/test/rules/parameter_assignments_test.dart
M pkg/linter/test/rules/prefer_adjacent_string_concatenation_test.dart
M pkg/linter/test/rules/prefer_asserts_in_initializer_lists_test.dart
M pkg/linter/test/rules/prefer_asserts_with_message_test.dart
M pkg/linter/test/rules/prefer_collection_literals_test.dart
M pkg/linter/test/rules/prefer_conditional_assignment_test.dart
M pkg/linter/test/rules/prefer_const_constructors_in_immutables_test.dart
M pkg/linter/test/rules/prefer_const_constructors_test.dart
M pkg/linter/test/rules/prefer_const_declarations_test.dart
M pkg/linter/test/rules/prefer_const_literals_to_create_immutables_test.dart
M pkg/linter/test/rules/prefer_constructors_over_static_methods_test.dart
M pkg/linter/test/rules/prefer_contains_test.dart
M pkg/linter/test/rules/prefer_double_quotes_test.dart
M pkg/linter/test/rules/prefer_expression_function_bodies_test.dart
M pkg/linter/test/rules/prefer_final_fields_test.dart
M pkg/linter/test/rules/prefer_final_in_for_each_test.dart
M pkg/linter/test/rules/prefer_final_locals_test.dart
M pkg/linter/test/rules/prefer_final_parameters_test.dart
M pkg/linter/test/rules/prefer_for_elements_to_map_fromIterable_test.dart
M pkg/linter/test/rules/prefer_foreach_test.dart
M pkg/linter/test/rules/prefer_function_declarations_over_variables_test.dart
M pkg/linter/test/rules/prefer_generic_function_type_aliases_test.dart
M pkg/linter/test/rules/prefer_if_elements_to_conditional_expressions_test.dart
M pkg/linter/test/rules/prefer_if_null_operators_test.dart
M pkg/linter/test/rules/prefer_initializing_formals_test.dart
M pkg/linter/test/rules/prefer_inlined_adds_test.dart
M pkg/linter/test/rules/prefer_int_literals_test.dart
M pkg/linter/test/rules/prefer_interpolation_to_compose_strings_test.dart
M pkg/linter/test/rules/prefer_is_empty_test.dart
M pkg/linter/test/rules/prefer_is_not_empty_test.dart
M pkg/linter/test/rules/prefer_is_not_operator_test.dart
M pkg/linter/test/rules/prefer_iterable_whereType_test.dart
M pkg/linter/test/rules/prefer_mixin_test.dart
M pkg/linter/test/rules/prefer_null_aware_method_calls_test.dart
M pkg/linter/test/rules/prefer_null_aware_operators_test.dart
M pkg/linter/test/rules/prefer_relative_imports_test.dart
M pkg/linter/test/rules/prefer_single_quotes_test.dart
M pkg/linter/test/rules/prefer_spread_collections_test.dart
M pkg/linter/test/rules/prefer_typing_uninitialized_variables_test.dart
M pkg/linter/test/rules/prefer_void_to_null_test.dart
M pkg/linter/test/rules/provide_deprecation_message_test.dart
M pkg/linter/test/rules/public_member_api_docs_test.dart
M pkg/linter/test/rules/recursive_getters_test.dart
M pkg/linter/test/rules/require_trailing_commas_test.dart
M pkg/linter/test/rules/simple_directive_paths_test.dart
M pkg/linter/test/rules/simplify_variable_pattern_test.dart
M pkg/linter/test/rules/sized_box_for_whitespace_test.dart
M pkg/linter/test/rules/sized_box_shrink_expand_test.dart
M pkg/linter/test/rules/slash_for_doc_comments_test.dart
M pkg/linter/test/rules/sort_child_properties_last_test.dart
M pkg/linter/test/rules/sort_constructors_first_test.dart
M pkg/linter/test/rules/sort_unnamed_constructors_first_test.dart
M pkg/linter/test/rules/specify_nonobvious_local_variable_types_test.dart
M pkg/linter/test/rules/specify_nonobvious_property_types_test.dart
M pkg/linter/test/rules/strict_top_level_inference_test.dart
M pkg/linter/test/rules/switch_on_type_test.dart
M pkg/linter/test/rules/test_types_in_equals_test.dart
M pkg/linter/test/rules/throw_in_finally_test.dart
M pkg/linter/test/rules/tighten_type_of_initializing_formals_test.dart
M pkg/linter/test/rules/type_annotate_public_apis_test.dart
M pkg/linter/test/rules/type_init_formals_test.dart
M pkg/linter/test/rules/type_literal_in_constant_pattern_test.dart
M pkg/linter/test/rules/unawaited_futures_test.dart
M pkg/linter/test/rules/unintended_html_in_doc_comment_test.dart
M pkg/linter/test/rules/unnecessary_async_test.dart
M pkg/linter/test/rules/unnecessary_await_in_return_test.dart
M pkg/linter/test/rules/unnecessary_brace_in_string_interps_test.dart
M pkg/linter/test/rules/unnecessary_breaks_test.dart
M pkg/linter/test/rules/unnecessary_const_in_enum_constructor_test.dart
M pkg/linter/test/rules/unnecessary_const_test.dart
M pkg/linter/test/rules/unnecessary_constructor_name_test.dart
M pkg/linter/test/rules/unnecessary_final_test.dart
M pkg/linter/test/rules/unnecessary_getters_setters_test.dart
M pkg/linter/test/rules/unnecessary_ignore_test.dart
M pkg/linter/test/rules/unnecessary_lambdas_test.dart
M pkg/linter/test/rules/unnecessary_late_test.dart
M pkg/linter/test/rules/unnecessary_library_directive_test.dart
M pkg/linter/test/rules/unnecessary_library_name_test.dart
M pkg/linter/test/rules/unnecessary_new_test.dart
M pkg/linter/test/rules/unnecessary_null_aware_assignments_test.dart
M pkg/linter/test/rules/unnecessary_null_aware_operator_on_extension_on_nullable_test.dart
M pkg/linter/test/rules/unnecessary_null_checks_test.dart
M pkg/linter/test/rules/unnecessary_null_in_if_null_operators_test.dart
M pkg/linter/test/rules/unnecessary_nullable_for_final_variable_declarations_test.dart
M pkg/linter/test/rules/unnecessary_overrides_test.dart
M pkg/linter/test/rules/unnecessary_parenthesis_test.dart
M pkg/linter/test/rules/unnecessary_primary_constructor_body_test.dart
M pkg/linter/test/rules/unnecessary_raw_strings_test.dart
M pkg/linter/test/rules/unnecessary_statements_test.dart
M pkg/linter/test/rules/unnecessary_string_escapes_test.dart
M pkg/linter/test/rules/unnecessary_string_interpolations_test.dart
M pkg/linter/test/rules/unnecessary_this_test.dart
M pkg/linter/test/rules/unnecessary_to_list_in_spreads_test.dart
M pkg/linter/test/rules/unnecessary_type_name_in_constructor_test.dart
M pkg/linter/test/rules/unnecessary_unawaited_test.dart
M pkg/linter/test/rules/unnecessary_underscores_test.dart
M pkg/linter/test/rules/unreachable_from_main_test.dart
M pkg/linter/test/rules/unrelated_type_equality_checks_test.dart
M pkg/linter/test/rules/unsafe_variance_test.dart
M pkg/linter/test/rules/use_build_context_synchronously_test.dart
M pkg/linter/test/rules/use_colored_box_test.dart
M pkg/linter/test/rules/use_declaring_parameters_test.dart
M pkg/linter/test/rules/use_decorated_box_test.dart
M pkg/linter/test/rules/use_enums_test.dart
M pkg/linter/test/rules/use_full_hex_values_for_flutter_colors_test.dart
M pkg/linter/test/rules/use_function_type_syntax_for_parameters_test.dart
M pkg/linter/test/rules/use_if_null_to_convert_nulls_to_bools_test.dart
M pkg/linter/test/rules/use_is_even_rather_than_modulo_test.dart
M pkg/linter/test/rules/use_key_in_widget_constructors_test.dart
M pkg/linter/test/rules/use_late_for_private_fields_and_variables_test.dart
M pkg/linter/test/rules/use_named_constants_test.dart
M pkg/linter/test/rules/use_null_aware_elements_test.dart
M pkg/linter/test/rules/use_primary_constructors_test.dart
M pkg/linter/test/rules/use_raw_strings_test.dart
M pkg/linter/test/rules/use_rethrow_when_possible_test.dart
M pkg/linter/test/rules/use_setters_to_change_properties_test.dart
M pkg/linter/test/rules/use_string_buffers_test.dart
M pkg/linter/test/rules/use_string_in_part_of_directives_test.dart
M pkg/linter/test/rules/use_super_parameters_test.dart
M pkg/linter/test/rules/use_test_throws_matchers_test.dart
M pkg/linter/test/rules/use_to_and_as_if_applicable_test.dart
M pkg/linter/test/rules/use_truncating_division_test.dart
M pkg/linter/test/rules/valid_regexps_test.dart
M pkg/linter/test/rules/var_with_no_type_annotation_test.dart
M pkg/linter/test/rules/void_checks_test.dart

Change size: XL

Delta: 243 files changed, 2391 insertions(+), 2391 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Brian Wilkerson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages