[L] Change in dart/sdk[main]: [dart2wasm] Use M / M<id> for module names
0 views
Skip to first unread message
Nate Biggs (Gerrit)
Jun 22, 2026, 12:14:09 PM (2 days ago) Jun 22
to Martin Kustermann, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Nate Biggs voted and added 3 comments![]( "Open in Gerrit")
Votes added by Nate Biggs
| Code-Review | +1 |
3 comments
Patchset-level comments
File pkg/dart2wasm/test/record_use_test.dart
Line 79, Patchset 5 (Latest):
final id = unit == 'M' ? 0 : int.parse(unit.substring(1));Nate Biggs . unresolved
Can we use `'${moduleNameToId(unit) + 1}'` here?
File tests/web/wasm/source_map_simple_lib.dart
Line 138, Patchset 5 (Latest):
final moduleId = moduleIdString == 'M'Nate Biggs . unresolved
Ditto use `moduleNameToId`
Related details
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Jun 23, 2026, 3:54:20 AM (20 hours ago) Jun 23
to Nate Biggs, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Martin Kustermann voted and added 3 comments![]( "Open in Gerrit")
Votes added by Martin Kustermann
| Commit-Queue | +2 |
3 comments
Patchset-level comments
File pkg/dart2wasm/test/record_use_test.dart
Line 79, Patchset 5:
final id = unit == 'M' ? 0 : int.parse(unit.substring(1));Nate Biggs . resolved
Can we use `'${moduleNameToId(unit) + 1}'` here?
Martin Kustermann
Done
File tests/web/wasm/source_map_simple_lib.dart
Line 138, Patchset 5:
final moduleId = moduleIdString == 'M'Nate Biggs . resolved
Martin KustermannDitto use `moduleNameToId`
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Jun 23, 2026, 4:32:10 AM (19 hours ago) Jun 23
to Nate Biggs, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Martin Kustermann voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Jun 23, 2026, 6:54:50 AM (17 hours ago) Jun 23
to Nate Biggs, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Nate Biggs
Martin Kustermann added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Martin Kustermann . resolved
PTAL, it lost the +1 bit after addressing comments & rebasing
Related details
Attention is currently required from:
- Nate Biggs
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Biggs (Gerrit)
Jun 23, 2026, 11:09:32 AM (13 hours ago) Jun 23
to Martin Kustermann, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Nate Biggs voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Jun 23, 2026, 1:59:50 PM (10 hours ago) Jun 23
to Nate Biggs, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Martin Kustermann voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 23, 2026, 2:00:20 PM (10 hours ago) Jun 23
to Martin Kustermann, Nate Biggs, dart2wasm-t...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[dart2wasm] Use M / M<id> for module names
The module names can appear in stack traces (**). In order to make
stack trace parsing safe and allow recognizing the module name in
stack trace frames we are limited by the characters we can use.
At the bare minimum we should use url-safe characters instead of
what we do now. But the names aren't so important, because
a) it's one char in a wasm module
b) deferred modules only import main module (never other
deferred modules)
So whether we can save an extra 1-3 bytes in the name isn't so
important. We only really care about the main module's
import name, as deferred modules use that.
This CL switches us to use
* `M` (main module)
* `M<id>` (deferred modules)
naming convention
We no longer distinguish `--minify` from `--no-minify`.
=> Easy to see module id by looking at a name
=> Easy to parse
(**) Wasm runtimes that don't know where the wasm module bytes
come from (i.e. no known uri / file name) will fallback to
show module names in stack traces.
Change-Id: Id89d2a8f4a0150156f4c59e0feba0cd5af36ab57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/514840
Commit-Queue: Martin Kustermann <kuste...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Files:
- M pkg/dart2wasm/lib/modules.dart
- M pkg/dart2wasm/lib/util.dart
- M pkg/dart2wasm/test/ir_tests/always_throws.wat
- M pkg/dart2wasm/test/ir_tests/constant_string_ops.wat
- M pkg/dart2wasm/test/ir_tests/constructor.wat
- M pkg/dart2wasm/test/ir_tests/covariance_check.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant.multi_module_use.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant.multi_module_use_module1.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant.multi_module_use_module2.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant.type_use.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant.type_use_module1.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant_module1.wat
- M pkg/dart2wasm/test/ir_tests/deferred.constant_module2.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained.devirtualized.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained.devirtualized_module1.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained_module1.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained_module2.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained_module3.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained_module4.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained_module5.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained_module6.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained_module7.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained_module8.wat
- M pkg/dart2wasm/test/ir_tests/deferred.fine_grained_module9.wat
- M pkg/dart2wasm/test/ir_tests/deferred.init_at_startup.wat
- M pkg/dart2wasm/test/ir_tests/deferred.init_at_startup_module1.wat
- M pkg/dart2wasm/test/ir_tests/deferred.type_checks.wat
- M pkg/dart2wasm/test/ir_tests/deferred.type_checks_module1.wat
- M pkg/dart2wasm/test/ir_tests/dispatch_table_reuse.wat
- M pkg/dart2wasm/test/ir_tests/dispatch_table_reuse_module1.wat
- M pkg/dart2wasm/test/ir_tests/dyn_closure.wat
- M pkg/dart2wasm/test/ir_tests/dyn_closure_function_apply.wat
- M pkg/dart2wasm/test/ir_tests/dyn_closure_function_apply_named.wat
- M pkg/dart2wasm/test/ir_tests/dynamic_call.wat
- M pkg/dart2wasm/test/ir_tests/external_effect.wat
- M pkg/dart2wasm/test/ir_tests/globals.wat
- M pkg/dart2wasm/test/ir_tests/hello.wat
- M pkg/dart2wasm/test/ir_tests/import_name.wat
- M pkg/dart2wasm/test/ir_tests/import_name_module1.wat
- M pkg/dart2wasm/test/ir_tests/interop.bool.wat
- M pkg/dart2wasm/test/ir_tests/interop.double.wat
- M pkg/dart2wasm/test/ir_tests/interop.int.wat
- M pkg/dart2wasm/test/ir_tests/interop.num.wat
- M pkg/dart2wasm/test/ir_tests/interop.string.wat
- M pkg/dart2wasm/test/ir_tests/js_inline.wat
- M pkg/dart2wasm/test/ir_tests/math_min_max.wat
- M pkg/dart2wasm/test/ir_tests/memory_use.wat
- M pkg/dart2wasm/test/ir_tests/pure_function.wat
- M pkg/dart2wasm/test/ir_tests/standalone.wat
- M pkg/dart2wasm/test/ir_tests/try_blocks.wat
- M pkg/dart2wasm/test/ir_tests/type_brand.wat
- M pkg/dart2wasm/test/ir_tests/type_nobrand.wat
- M pkg/dart2wasm/test/ir_tests/wasm_function_from_function.wat
- M pkg/dart2wasm/test/record_use_test.dart
- M tests/web/wasm/source_map_simple_lib.dart
- M tests/web/wasm/source_map_simple_optimized_deferred_test.dart
- M tests/web/wasm/source_map_simple_optimized_test.dart
- M tests/web/wasm/source_map_simple_test.dart
Change size: L
Delta: 60 files changed, 246 insertions(+), 245 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Biggs
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages