[L] Change in dart/sdk[main]: Fix simple_directive_paths violations in compiler
Kevin Moore (Gerrit)
Kevin Moore voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kevin Moore
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Tried out my new lint
noticed the directives weren't sorted.
Related details
- Nicholas Shahan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson added 1 comment![]( "Open in Gerrit")
Tried out my new lint
noticed the directives weren't sorted.
Not all users sort their directives. Are you sure that the fix should assume that the directives need to be sorted? We do have a separate 'sort directives' code action that will sort them if that's what the user wants.
Related details
- Kevin Moore
- Nicholas Shahan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Moore (Gerrit)
Kevin Moore added 1 comment![]( "Open in Gerrit")
Brian WilkersonTried out my new lint
noticed the directives weren't sorted.
Not all users sort their directives. Are you sure that the fix should assume that the directives need to be sorted? We do have a separate 'sort directives' code action that will sort them if that's what the user wants.
Oh I know! When I applied the lint there were several places where the fix was "weird" because the existing directives were mostly sorted.
I figured I'd see if the compiler folks liked...or not...
Related details
- Brian Wilkerson
- Nicholas Shahan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson added 1 comment![]( "Open in Gerrit")
Brian WilkersonTried out my new lint
noticed the directives weren't sorted.
Kevin MooreNot all users sort their directives. Are you sure that the fix should assume that the directives need to be sorted? We do have a separate 'sort directives' code action that will sort them if that's what the user wants.
Oh I know! When I applied the lint there were several places where the fix was "weird" because the existing directives were mostly sorted.
I figured I'd see if the compiler folks liked...or not...
The fact that not all of our own code is sorted strongly suggests to me that that fix should only sort the directives if the `directives_ordering` lint is enabled.
Related details
- Kevin Moore
- Nicholas Shahan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Moore (Gerrit)
Kevin Moore added 1 comment![]( "Open in Gerrit")
Brian WilkersonTried out my new lint
noticed the directives weren't sorted.
Kevin MooreNot all users sort their directives. Are you sure that the fix should assume that the directives need to be sorted? We do have a separate 'sort directives' code action that will sort them if that's what the user wants.
Brian WilkersonOh I know! When I applied the lint there were several places where the fix was "weird" because the existing directives were mostly sorted.
I figured I'd see if the compiler folks liked...or not...
The fact that not all of our own code is sorted strongly suggests to me that that fix should only sort the directives if the `directives_ordering` lint is enabled.
- Brian Wilkerson
- Nicholas Shahan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Shahan (Gerrit)
Nicholas Shahan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Shahan
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
- Brian Wilkerson
- Kevin Moore
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Fix simple_directive_paths violations in compiler
Also enabled directive ordering, as is common
Removed `use_null_aware_elements` explicitly, since it's in the included set
- M pkg/compiler/analysis_options.yaml
- M pkg/compiler/lib/src/common/codegen.dart
- M pkg/compiler/lib/src/compiler.dart
- M pkg/compiler/lib/src/constants/values.dart
- M pkg/compiler/lib/src/deferred_load/algorithm_state.dart
- M pkg/compiler/lib/src/deferred_load/entity_data_info.dart
- M pkg/compiler/lib/src/deferred_load/import_set.dart
- M pkg/compiler/lib/src/deferred_load/output_unit.dart
- M pkg/compiler/lib/src/deferred_load/program_split_constraints/builder.dart
- M pkg/compiler/lib/src/deferred_load/work_queue.dart
- M pkg/compiler/lib/src/elements/types.dart
- M pkg/compiler/lib/src/inferrer/builder.dart
- M pkg/compiler/lib/src/inferrer/computable.dart
- M pkg/compiler/lib/src/inferrer/engine.dart
- M pkg/compiler/lib/src/inferrer/trivial.dart
- M pkg/compiler/lib/src/inferrer/type_graph_dump.dart
- M pkg/compiler/lib/src/inferrer/types.dart
- M pkg/compiler/lib/src/io/code_output.dart
- M pkg/compiler/lib/src/io/kernel_source_information.dart
- M pkg/compiler/lib/src/io/location_provider.dart
- M pkg/compiler/lib/src/io/source_file.dart
- M pkg/compiler/lib/src/io/source_information.dart
- M pkg/compiler/lib/src/io/source_map_builder.dart
- M pkg/compiler/lib/src/ir/impact_data.dart
- M pkg/compiler/lib/src/ir/modular.dart
- M pkg/compiler/lib/src/ir/visitors.dart
- M pkg/compiler/lib/src/js/js.dart
- M pkg/compiler/lib/src/js_backend/backend_impact.dart
- M pkg/compiler/lib/src/js_backend/constant_emitter.dart
- M pkg/compiler/lib/src/js_backend/deferred_holder_expression.dart
- M pkg/compiler/lib/src/js_backend/enqueuer.dart
- M pkg/compiler/lib/src/js_backend/impact_transformer.dart
- M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart
- M pkg/compiler/lib/src/js_backend/namer.dart
- M pkg/compiler/lib/src/js_backend/records_codegen.dart
- M pkg/compiler/lib/src/js_backend/runtime_types_new.dart
- M pkg/compiler/lib/src/js_backend/specialized_checks.dart
- M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart
- M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
- M pkg/compiler/lib/src/js_emitter/instantiation_stub_generator.dart
- M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart
- M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
- M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart
- M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart
- M pkg/compiler/lib/src/js_model/closure.dart
- M pkg/compiler/lib/src/js_model/element_map.dart
- M pkg/compiler/lib/src/js_model/element_map_impl.dart
- M pkg/compiler/lib/src/js_model/env.dart
- M pkg/compiler/lib/src/js_model/js_strategy.dart
- M pkg/compiler/lib/src/js_model/js_world.dart
- M pkg/compiler/lib/src/js_model/js_world_builder.dart
- M pkg/compiler/lib/src/js_model/type_recipe.dart
- M pkg/compiler/lib/src/kernel/element_map.dart
- M pkg/compiler/lib/src/kernel/element_map_impl.dart
- M pkg/compiler/lib/src/kernel/env.dart
- M pkg/compiler/lib/src/kernel/kernel_impact.dart
- M pkg/compiler/lib/src/kernel/kernel_strategy.dart
- M pkg/compiler/lib/src/kernel/kernel_world.dart
- M pkg/compiler/lib/src/kernel/transformations/modular/factory_specializer.dart
- M pkg/compiler/lib/src/serialization/serialization.dart
- M pkg/compiler/lib/src/ssa/builder.dart
- M pkg/compiler/lib/src/ssa/codegen.dart
- M pkg/compiler/lib/src/ssa/locals_handler.dart
- M pkg/compiler/lib/src/ssa/logging.dart
- M pkg/compiler/lib/src/ssa/optimize.dart
- M pkg/compiler/lib/src/ssa/ssa.dart
- M pkg/compiler/lib/src/ssa/type_builder.dart
- M pkg/compiler/lib/src/universe/codegen_world_builder.dart
- M pkg/compiler/lib/src/universe/resolution_world_builder.dart
- M pkg/compiler/lib/src/universe/use.dart
- M pkg/compiler/lib/src/util/memory_source_file_helper.dart
- M pkg/compiler/tool/dart2js_stress.dart
- M pkg/compiler/tool/hot_reload_launcher.dart
- M pkg/compiler/tool/modular_test_suite_helper.dart
- M pkg/compiler/tool/track_memory.dart
Code-Review: +1 by Nicholas Shahan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |