[L] Change in dart/sdk[main]: Elements. Write TypeAliasElement2.

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
Mar 13, 2025, 4:30:33 PM3/13/25
to Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I20f6faf818fe9fb18bdfc2587288131609920f55
Gerrit-Change-Number: 415360
Gerrit-PatchSet: 1
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Thu, 13 Mar 2025 20:30:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 13, 2025, 4:40:50 PM3/13/25
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Konstantin Shcheglov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I20f6faf818fe9fb18bdfc2587288131609920f55
Gerrit-Change-Number: 415360
Gerrit-PatchSet: 1
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Thu, 13 Mar 2025 20:40:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 13, 2025, 7:04:59 PM3/13/25
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Gerrit-Comment-Date: Thu, 13 Mar 2025 23:04:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 13, 2025, 11:30:13 PM3/13/25
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Gerrit-Comment-Date: Fri, 14 Mar 2025 03:30:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 14, 2025, 10:45:34 AM3/14/25
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Gerrit-Comment-Date: Fri, 14 Mar 2025 14:45:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 14, 2025, 1:47:24 PM3/14/25
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Konstantin Shcheglov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I20f6faf818fe9fb18bdfc2587288131609920f55
Gerrit-Change-Number: 415360
Gerrit-PatchSet: 2
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 17:47:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 14, 2025, 2:26:15 PM3/14/25
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Gerrit-Comment-Date: Fri, 14 Mar 2025 18:26:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Mar 14, 2025, 2:41:37 PM3/14/25
to Konstantin Shcheglov, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Elements. Write TypeAliasElement2.
Change-Id: I20f6faf818fe9fb18bdfc2587288131609920f55
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
  • M pkg/analyzer/test/src/dart/resolution/ast_rewrite_test.dart
  • M pkg/analyzer/test/src/dart/resolution/constant_pattern_test.dart
  • M pkg/analyzer/test/src/dart/resolution/constant_test.dart
  • M pkg/analyzer/test/src/dart/resolution/function_expression_invocation_test.dart
  • M pkg/analyzer/test/src/dart/resolution/function_reference_test.dart
  • M pkg/analyzer/test/src/dart/resolution/function_type_alias_test.dart
  • M pkg/analyzer/test/src/dart/resolution/generic_type_alias_test.dart
  • M pkg/analyzer/test/src/dart/resolution/method_invocation_test.dart
  • M pkg/analyzer/test/src/dart/resolution/named_type_test.dart
  • M pkg/analyzer/test/src/dart/resolution/non_nullable_test.dart
  • M pkg/analyzer/test/src/dart/resolution/object_pattern_test.dart
  • M pkg/analyzer/test/src/dart/resolution/postfix_expression_test.dart
  • M pkg/analyzer/test/src/dart/resolution/type_literal_test.dart
  • M pkg/analyzer/test/src/diagnostics/implements_deferred_class_test.dart
  • M pkg/analyzer/test/src/diagnostics/implements_repeated_test.dart
  • M pkg/analyzer/test/src/summary/elements/class_test.dart
  • M pkg/analyzer/test/src/summary/elements/const_test.dart
  • M pkg/analyzer/test/src/summary/elements/default_value_test.dart
  • M pkg/analyzer/test/src/summary/elements/function_type_annotation_test.dart
  • M pkg/analyzer/test/src/summary/elements/mixin_test.dart
  • M pkg/analyzer/test/src/summary/elements/type_alias_test.dart
  • M pkg/analyzer/test/src/summary/elements/type_inference_test.dart
  • M pkg/analyzer/test/src/summary/elements/types_test.dart
  • M pkg/analyzer/test/src/summary/top_level_inference_test.dart
  • M pkg/analyzer/test/util/element_printer.dart
Change size: L
Delta: 25 files changed, 270 insertions(+), 270 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I20f6faf818fe9fb18bdfc2587288131609920f55
Gerrit-Change-Number: 415360
Gerrit-PatchSet: 3
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages