[M] Change in dart/sdk[main]: [vm] Replace GCC __builtin_expect with C++20 [[likely]] attributes.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
4:51 PM (4 hours ago) 4:51 PM
to Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
5:05 PM (3 hours ago) 5:05 PM
to Ryan Macnak, Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Markov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
5:25 PM (3 hours ago) 5:25 PM
to Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
5:25 PM (3 hours ago) 5:25 PM
to Ryan Macnak, Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm] Replace GCC __builtin_expect with C++20 [[likely]] attributes.
MSVC has no analogue of __builtin_expect but does support the standard attribute.
TEST=ci
Change-Id: Ide1edaf88425677bce784db4400a72be64e84346
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481162
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
Files:
- M runtime/lib/object.cc
- M runtime/vm/app_snapshot.cc
- M runtime/vm/dart_entry.cc
- M runtime/vm/heap/heap.cc
- M runtime/vm/heap/marker.cc
- M runtime/vm/heap/page.h
- M runtime/vm/heap/pages.cc
- M runtime/vm/heap/pages.h
- M runtime/vm/heap/pointer_block.h
- M runtime/vm/heap/sampler.cc
- M runtime/vm/heap/scavenger.cc
- M runtime/vm/heap/scavenger.h
- M runtime/vm/heap/sweeper.cc
- M runtime/vm/interpreter.cc
- M runtime/vm/interpreter.h
- M runtime/vm/message_snapshot.cc
- M runtime/vm/module_snapshot.cc
- M runtime/vm/native_entry.cc
- M runtime/vm/object.cc
- M runtime/vm/object_graph_copy.cc
- M runtime/vm/runtime_entry.cc
- M runtime/vm/simulator_arm.cc
- M runtime/vm/simulator_arm64.cc
- M runtime/vm/simulator_memory.h
- M runtime/vm/simulator_riscv.cc
Change size: M
Delta: 25 files changed, 103 insertions(+), 99 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Markov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages