[M] Change in dart/sdk[main]: analyzer: For must_be_immutable, check fields declared in primary con...
0 views
Skip to first unread message
Samuel Rawlins (Gerrit)
Dec 18, 2025, 2:22:27 PM (3 days ago) Dec 18
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Dec 18, 2025, 2:26:59 PM (3 days ago) Dec 18
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Brian Wilkerson . resolved
LGTM, but this is in the analyzer package, so you'll need another reviewer.
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 18, 2025, 2:27:59 PM (3 days ago) Dec 18
to Paul Berry, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Brian Wilkerson . resolved
LGTM, but this is in the analyzer package, so you'll need another reviewer.
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Dec 18, 2025, 2:30:16 PM (3 days ago) Dec 18
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 18, 2025, 2:35:13 PM (3 days ago) Dec 18
to Paul Berry, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 18, 2025, 2:35:23 PM (3 days ago) Dec 18
to Samuel Rawlins, Paul Berry, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
analyzer: For must_be_immutable, check fields declared in primary constructors
Work towards https://github.com/dart-lang/sdk/issues/62268
Change-Id: I9293e8ff8d4cdf86136b8fd558dfee7955787741
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/469081
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analyzer/lib/src/error/best_practices_verifier.dart
- A pkg/analyzer/lib/src/error/immutable_verifier.dart
- M pkg/analyzer/test/src/diagnostics/must_be_immutable_test.dart
Change size: M
Delta: 3 files changed, 140 insertions(+), 94 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Berry, +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 19, 2025, 10:52:35 AM (2 days ago) Dec 19
to Samuel Rawlins, Commit Queue, Paul Berry, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
File pkg/analyzer/lib/src/error/immutable_verifier.dart
Line 108, Patchset 2 (Latest):
.where((f) => !f.isStatic && !f.isFinal && !f.isOriginGetterSetter)Konstantin Shcheglov . unresolved
I think the logic is easier to understand if it were listing origins that we support than negating them. It works for now as is, but it would be easier to find interesting places later.
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages