[S] Change in dart/sdk[main]: [vm] Remove irregular canonical bits.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Apr 21, 2026, 5:50:42 PM (18 hours ago) Apr 21
to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Apr 21, 2026, 6:01:15 PM (17 hours ago) Apr 21
to Ryan Macnak, Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Aprelev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Apr 21, 2026, 6:05:00 PM (17 hours ago) Apr 21
to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 21, 2026, 6:05:19 PM (17 hours ago) Apr 21
to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org, vm-...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[vm] Remove irregular canonical bits.
Some objects have their canonical bit set but don't have the deeply immutable bit set. It's simpler if they have this bit clear so there is only cluster need, and these objects are instances of VM-internal classes that don't really do canonicalization.
Also give the oddballs their header hash while doing the rest of their initialization. This makes it easier to use the as snapshot base objects when there is no finalize VM isolate step.
TEST=ci
Change-Id: I7bdf7dc59b04ae30f49c5c67c0dc4f69c2d2524f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/497121
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Files:
- M runtime/vm/object.cc
Change size: S
Delta: 1 file changed, 10 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Aprelev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages