[S] Change in dart/sdk[main]: [vm] Synchronize between switchable call patching and loading in the ...

0 views
Skip to first unread message

Ryan Macnak (Gerrit)

unread,
Oct 20, 2025, 5:41:30 PM (23 hours ago) Oct 20
to Liam Appelbe, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Liam Appelbe

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Liam Appelbe
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8938b3243144a24febaa58a48a98fe6d328fd6be
Gerrit-Change-Number: 456105
Gerrit-PatchSet: 2
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Liam Appelbe <li...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Liam Appelbe <li...@google.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 21:41:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Liam Appelbe (Gerrit)

unread,
Oct 20, 2025, 6:36:38 PM (22 hours ago) Oct 20
to Ryan Macnak, Liam Appelbe, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak

Liam Appelbe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Macnak
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8938b3243144a24febaa58a48a98fe6d328fd6be
Gerrit-Change-Number: 456105
Gerrit-PatchSet: 2
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Liam Appelbe <li...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 22:36:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ryan Macnak (Gerrit)

unread,
Oct 20, 2025, 8:51:03 PM (19 hours ago) Oct 20
to Liam Appelbe, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org

Ryan Macnak voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8938b3243144a24febaa58a48a98fe6d328fd6be
Gerrit-Change-Number: 456105
Gerrit-PatchSet: 2
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Liam Appelbe <li...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 00:50:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Oct 20, 2025, 8:51:17 PM (19 hours ago) Oct 20
to Ryan Macnak, Liam Appelbe, rev...@dartlang.org, vm-...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[vm] Synchronize between switchable call patching and loading in the runtime.

TEST=tsan
Bug: https://github.com/dart-lang/sdk/issues/61718
Change-Id: I8938b3243144a24febaa58a48a98fe6d328fd6be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456105
Reviewed-by: Liam Appelbe <li...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Files:
  • M runtime/vm/code_patcher_x64.cc
  • M runtime/vm/instructions_arm.cc
  • M runtime/vm/instructions_arm64.cc
  • M runtime/vm/instructions_riscv.cc
Change size: S
Delta: 4 files changed, 10 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Liam Appelbe
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8938b3243144a24febaa58a48a98fe6d328fd6be
Gerrit-Change-Number: 456105
Gerrit-PatchSet: 3
Gerrit-Owner: Ryan Macnak <rma...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages