[XS] Change in dart/sdk[main]: [build] Don't export API symbols in gen

Ryan Macnak (Gerrit)

unread,

Oct 2, 2023, 4:09:33 PM10/2/23

to Daco Harkes, rev...@dartlang.org, vm-...@dartlang.org

Attention is currently required from: Daco Harkes.

Ryan Macnak would like Daco Harkes to review this change.

[build] Don't export API symbols in gen_snapshot.

TEST=flutter
Bug: https://github.com/flutter/flutter/issues/134857
Change-Id: Id1b68c818f12adf06e46749d64a284e368e15058
---
M runtime/bin/BUILD.gn
1 file changed, 0 insertions(+), 2 deletions(-)

diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index 38370e5..7245e63 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -224,8 +224,6 @@
       ]
     }
 
-    configs += [ ":export_api_symbols" ]
-
     if (is_win) {
       libs = [
         "iphlpapi.lib",

To view, visit change 329200. To unsubscribe, or for help writing mail filters, visit settings.

Ryan Macnak (Gerrit)

unread,

Oct 2, 2023, 4:09:34 PM10/2/23

to rev...@dartlang.org, vm-...@dartlang.org, Daco Harkes, CBuild, Commit Queue

Attention is currently required from: Daco Harkes.

View Change

To view, visit change 329200. To unsubscribe, or for help writing mail filters, visit settings.

Daco Harkes (Gerrit)

unread,

Oct 2, 2023, 9:22:39 PM10/2/23

to Ryan Macnak, rev...@dartlang.org, vm-...@dartlang.org, CBuild, Commit Queue

Attention is currently required from: Ryan Macnak.

Patch set 2:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #2:
  lgtm

To view, visit change 329200. To unsubscribe, or for help writing mail filters, visit settings.

Ryan Macnak (Gerrit)

unread,

Oct 3, 2023, 10:38:19 AM10/3/23

to rev...@dartlang.org, vm-...@dartlang.org, Daco Harkes, CBuild, Commit Queue

Patch set 2:Commit-Queue +2

View Change

To view, visit change 329200. To unsubscribe, or for help writing mail filters, visit settings.

Commit Queue (Gerrit)

unread,

Oct 3, 2023, 10:38:35 AM10/3/23

to Ryan Macnak, rev...@dartlang.org, vm-...@dartlang.org, Daco Harkes, CBuild

Commit Queue submitted this change.

View Change

Approvals:
  Daco Harkes: Looks good to me, approved
  Ryan Macnak: Commit

[build] Don't export API symbols in gen_snapshot.

TEST=flutter
Bug: https://github.com/flutter/flutter/issues/134857
Change-Id: Id1b68c818f12adf06e46749d64a284e368e15058

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329200
Reviewed-by: Daco Harkes <dacoh...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>


---
M runtime/bin/BUILD.gn
1 file changed, 0 insertions(+), 2 deletions(-)

diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index 38370e5..7245e63 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -224,8 +224,6 @@
       ]
     }
 
-    configs += [ ":export_api_symbols" ]
-
     if (is_win) {
       libs = [
         "iphlpapi.lib",

To view, visit change 329200. To unsubscribe, or for help writing mail filters, visit settings.

CBuild (Gerrit)

unread,

Oct 3, 2023, 10:56:54 AM10/3/23

to Ryan Macnak, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org, Daco Harkes

go/dart-cbuild result: SUCCESS

Details: https://goto.google.com/dart-cbuild/find/2a30837626398ba3baa5f8d7d8ed9837b4a62f44

View Change

To view, visit change 329200. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

[XS] Change in dart/sdk[main]: [build] Don't export API symbols in gen_snapshot.

Ryan Macnak (Gerrit)

Ryan Macnak (Gerrit)

Daco Harkes (Gerrit)

Ryan Macnak (Gerrit)

Commit Queue (Gerrit)

CBuild (Gerrit)