[M] Change in dart/sdk[main]: [linter] Allow omit_local_variable_types annotations for dot shorthands
Nate Bosch (Gerrit)
Nate Bosch voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
- Brian Wilkerson
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson added 1 comment on change 565140![]( "Open in Gerrit")
Sorry for the long delay, I was ooo for a couple of weeks.
I agree that there's a bug here that needs to be fixed, but I don't like having to duplicate so much of the logic from the resolver about how context types flow through the language. This really feels like something that ought to be in the analyzer.
So I've added Konstantin to get his opinion and see whether we can make the situation better.
Related details
- Konstantin Shcheglov
- Nate Bosch
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Bosch (Gerrit)
Nate Bosch voted and added 1 comment on change 565140![]( "Open in Gerrit")
Votes added by Nate Bosch <nbo...@google.com>
| Auto-Submit | +1 |
1 comment
Sorry for the long delay, I was ooo for a couple of weeks.
I agree that there's a bug here that needs to be fixed, but I don't like having to duplicate so much of the logic from the resolver about how context types flow through the language. This really feels like something that ought to be in the analyzer.
So I've added Konstantin to get his opinion and see whether we can make the situation better.
There was also discussion years ago around potential deeper changes to the way this lint is implemented which might be worth considering a revisit if it could solve this too.
Related details
- Brian Wilkerson
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |