[L] Change in dart/sdk[main]: Fix cookie-date parsing to use the correct algorithm.
0 views
Skip to first unread message
Martin Kustermann (Gerrit)
Apr 21, 2026, 8:39:29 AM (yesterday) Apr 21
to Lasse Nielsen, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Lasse Nielsen
Martin Kustermann voted and added 2 comments![]( "Open in Gerrit")
Votes added by Martin Kustermann
| Code-Review | +1 |
2 comments
Commit Message
Line 11, Patchset 1 (Latest):
produce, rather than what the RFC specifies should be accepted.Martin Kustermann . unresolved
Could you like to a bug?
Could you link to the "prior parser change"?
File sdk/lib/_http/http_date.dart
Line 153, Patchset 1 (Latest):
bool maybeExpectChar(int charCode) {Martin Kustermann . unresolved
There's only one call site of this left now, you may inline it into `expectChar`.
Related details
Attention is currently required from:
- Lasse Nielsen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
8:38 AM (3 hours ago) 8:38 AM
to Martin Kustermann, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Lasse Nielsen added 2 comments![]( "Open in Gerrit")
Commit Message
Line 11, Patchset 1:
produce, rather than what the RFC specifies should be accepted.Martin Kustermann . resolved
Could you like to a bug?
Could you link to the "prior parser change"?
Lasse Nielsen
Done
File sdk/lib/_http/http_date.dart
There's only one call site of this left now, you may inline it into `expectChar`.
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
8:39 AM (3 hours ago) 8:39 AM
to Martin Kustermann, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Lasse Nielsen voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
9:14 AM (2 hours ago) 9:14 AM
to Lasse Nielsen, Martin Kustermann, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: sdk/lib/_http/http_date.dart
Insertions: 3, Deletions: 7.
@@ -150,16 +150,12 @@
onError(source, start, end);
}
- bool maybeExpectChar(int charCode) {
+ void expectChar(int charCode) {
if (index < end && source.codeUnitAt(index) == charCode) {
index++;
- return true;
+ } else {
+ throwError();
}
- return false;
- }
-
- void expectChar(int charCode) {
- if (!maybeExpectChar(charCode)) throwError();
}
// Detects one of three recognized formats.
```
Change information
Commit message:
Fix cookie-date parsing to use the correct algorithm.
A prior parser change made the parsing more restrictive,
only accepting the dart formats that a cookie creator should
produce, rather than what the RFC specifies should be accepted.
Now implements the specified algorithm again.
Bug: https://github.com/dart-lang/sdk/issues/62721
Prior over-optimisitc breaking change: https://dart-review.googlesource.com/c/sdk/+/448383
Change-Id: I4ed7cf2368d04063e0fc563ff8e64904bf0d3e1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/496080
Reviewed-by: Martin Kustermann <kuste...@google.com>
Commit-Queue: Lasse Nielsen <l...@google.com>
Files:
- M CHANGELOG.md
- M sdk/lib/_http/http_date.dart
- M sdk/lib/_http/http_parser.dart
- M tests/standalone/io/http_cookie_date_test.dart
Change size: L
Delta: 4 files changed, 597 insertions(+), 44 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Martin Kustermann
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages