[M] Change in dart/sdk[main]: [dart2wasm] CFG support for null and reference comparisons
0 views
Skip to first unread message
Søren Pedersen (Gerrit)
Oct 27, 2026, 11:18:16 AM (18 hours ago) Oct 27
to Martin Kustermann, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Søren Pedersen voted Commit-Queue+1 on change 570120![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
4:35 AM (1 hour ago) 4:35 AM
to Søren Pedersen, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Søren Pedersen
Martin Kustermann added 3 comments on change 570120![]( "Open in Gerrit")
File pkg/dart2wasm/lib/prod/cfg/to_wasm.dart
Line 169, Patchset 1 (Latest):
void visitComparison(Comparison instr) {Martin Kustermann . unresolved
I would assume we handle `null` the same in prod and dev compiler. Can this move into the base class?
Line 188, Patchset 1 (Latest):
}Martin Kustermann . unresolved
nit: Consider using early returns to avoid the deep nesting.
Line 203, Patchset 1 (Latest):
b.ref_eq();Martin Kustermann . unresolved
Is this actually correct? I think the `identical()` function is more complicated than just reference equality.
That may be backend specific and the base class could call e.g. an abstract `_identical()` method.
Related details
Attention is currently required from:
- Søren Pedersen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages