[M] Change in dart/sdk[main]: [build] Remove unused "exec_script" mode from gn_run_binary.py.

0 views

Skip to first unread message

Ryan Macnak (Gerrit)

unread,

3:23 PM (2 hours ago) 3:23 PM

to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org

Attention needed from Alexander Aprelev

Ryan Macnak voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Alexander Aprelev

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexander Aprelev (Gerrit)

unread,

3:28 PM (2 hours ago) 3:28 PM

to Ryan Macnak, Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org

Attention needed from Ryan Macnak

Alexander Aprelev voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Ryan Macnak

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Ryan Macnak (Gerrit)

unread,

3:33 PM (2 hours ago) 3:33 PM

to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org

Ryan Macnak voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

3:33 PM (2 hours ago) 3:33 PM

to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[build] Remove unused "exec_script" mode from gn_run_binary.py.

Change-Id: Ie7d184dfe1694985fdff318736f34b45267a5bf3

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509141

Reviewed-by: Alexander Aprelev <a...@google.com>

Commit-Queue: Ryan Macnak <rma...@google.com>

Files:

M build/dart/dart_action.gni
M build/gn_run_binary.py
M tools/debian_package/BUILD.gn
M utils/compile_platform.gni
M utils/dart2wasm/BUILD.gn
M utils/kernel-service/BUILD.gn

Change size: M

Delta: 6 files changed, 15 insertions(+), 35 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alexander Aprelev

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages