[XL] Change in dart/sdk[main]: [analyzer] Migrates to `contexMessages` from `analyzer_testing` package
0 views
Skip to first unread message
Felipe Morschel (Gerrit)
Sep 29, 2025, 11:56:12 AMSep 29
to dart-analys...@google.com, rev...@dartlang.org
Felipe Morschel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[analyzer] Migrates to `contexMessages` from `analyzer_testing` package
This also includes some small refactorings for parameter names to start using the diagnostic wording instead of error. As well as a small change to `contextMessage` and related to use a list of `Pattern`s instead of a single `String` for better matching.
In future CLs, the TODOs added in this one will be addressed so we can fully migrate this. Added them because of the size of the CL.
Change-Id: I5557668a1baed98faff977255c9f22e0d9d96008
Change information
Files:
- M pkg/analyzer/test/generated/class_member_parser_test.dart
- M pkg/analyzer/test/generated/collection_literal_parser_test.dart
- M pkg/analyzer/test/generated/complex_parser_test.dart
- M pkg/analyzer/test/generated/error_parser_test.dart
- M pkg/analyzer/test/generated/expression_parser_test.dart
- M pkg/analyzer/test/generated/extension_methods_parser_test.dart
- M pkg/analyzer/test/generated/formal_parameter_parser_test.dart
- M pkg/analyzer/test/generated/function_reference_parser_test.dart
- M pkg/analyzer/test/generated/generic_metadata_parser_test.dart
- M pkg/analyzer/test/generated/new_as_identifier_parser_test.dart
- M pkg/analyzer/test/generated/nnbd_parser_test.dart
- M pkg/analyzer/test/generated/non_hint_code_test.dart
- M pkg/analyzer/test/generated/parser_test_base.dart
- M pkg/analyzer/test/generated/patterns_parser_test.dart
- M pkg/analyzer/test/generated/recovery_parser_test.dart
- M pkg/analyzer/test/generated/simple_parser_test.dart
- M pkg/analyzer/test/generated/statement_parser_test.dart
- M pkg/analyzer/test/generated/strong_mode_test.dart
- M pkg/analyzer/test/generated/test_support.dart
- M pkg/analyzer/test/generated/top_level_parser_test.dart
- M pkg/analyzer/test/generated/variance_parser_test.dart
- M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
- M pkg/analyzer/test/src/dart/resolution/context_collection_resolution.dart
- M pkg/analyzer/test/src/dart/resolution/resolution.dart
- M pkg/analyzer/test/src/diagnostics/analysis_options/analysis_options_test_support.dart
- M pkg/analyzer/test/src/diagnostics/base_class_implemented_outside_of_library_test.dart
- M pkg/analyzer/test/src/diagnostics/case_expression_type_implements_equals_test.dart
- M pkg/analyzer/test/src/diagnostics/case_expression_type_is_not_switch_expression_subtype_test.dart
- M pkg/analyzer/test/src/diagnostics/const_eval_property_access_test.dart
- M pkg/analyzer/test/src/diagnostics/const_eval_throws_exception_test.dart
- M pkg/analyzer/test/src/diagnostics/const_eval_type_string_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
- M pkg/analyzer/test/src/diagnostics/getter_not_subtype_setter_types_test.dart
- M pkg/analyzer/test/src/diagnostics/inconsistent_language_version_override_test.dart
- M pkg/analyzer/test/src/diagnostics/invalid_constant_test.dart
- M pkg/analyzer/test/src/diagnostics/mixin_subtype_of_base_is_not_base_test.dart
- M pkg/analyzer/test/src/diagnostics/mixin_subtype_of_final_is_not_base_test.dart
- M pkg/analyzer/test/src/diagnostics/not_assigned_potentially_non_nullable_local_variable_test.dart
- M pkg/analyzer/test/src/diagnostics/parser_diagnostics.dart
- M pkg/analyzer/test/src/diagnostics/sdk_constraint_verifier_support.dart
- M pkg/analyzer/test/src/diagnostics/sdk_version_gt_gt_gt_operator_test.dart
- M pkg/analyzer/test/src/diagnostics/sdk_version_since_test.dart
- M pkg/analyzer/test/src/diagnostics/subtype_of_base_is_not_base_final_or_sealed_test.dart
- M pkg/analyzer/test/src/diagnostics/subtype_of_final_is_not_base_final_or_sealed_test.dart
- M pkg/analyzer/test/src/diagnostics/use_of_void_result_test.dart
- M pkg/analyzer/test/src/fasta/recovery/result_comparator_test.dart
- M pkg/analyzer/test/src/options/options_file_validator_test.dart
- M pkg/analyzer/test/src/options/options_rule_validator_test.dart
- M pkg/analyzer/test/src/task/strong/inferred_type_test.dart
- M pkg/analyzer_testing/api.txt
- M pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart
- M pkg/analyzer_testing/lib/src/analysis_rule/pub_package_resolution.dart
- M pkg/linter/test/rules/conditional_uri_does_not_exist_test.dart
- M pkg/linter/test/rules/use_build_context_synchronously_test.dart
- M pkg/linter/test/rules/use_super_parameters_test.dart
Change size: XL
Delta: 55 files changed, 1405 insertions(+), 1104 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Sep 29, 2025, 12:15:15 PMSep 29
to Samuel Rawlins, Paul Berry, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry and Samuel Rawlins
Felipe Morschel voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Paul Berry
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Sep 29, 2025, 5:28:13 PMSep 29
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, Paul Berry, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel, Paul Berry and Samuel Rawlins
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
File pkg/analyzer/test/src/dart/constant/evaluation_test.dart
Line 3219, Patchset 2 (Latest):
textContains: [Brian Wilkerson . resolved
This seems a little odd. The whole point of `textContains` is to test for a piece of the message rather than the whole message so that messages can be updated without breaking tests.
In this case, for example, the part we (probably) care about is that the class name (`RequiresNonEmptyList`) is displayed. (We can't really tell the difference between what we care about and what was accidentally included, but that's my guess.)
It would be nice to minimize the text being compared, but unless Paul or Konstantin cares I'm not going to stop the CL from landing because of it.
Related details
Attention is currently required from:
- Felipe Morschel
- Paul Berry
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Sep 29, 2025, 5:49:58 PMSep 29
to Brian Wilkerson, Samuel Rawlins, Paul Berry, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
File pkg/analyzer/test/src/dart/constant/evaluation_test.dart
Line 3219, Patchset 2 (Latest):
textContains: [Brian Wilkerson . resolved
This seems a little odd. The whole point of `textContains` is to test for a piece of the message rather than the whole message so that messages can be updated without breaking tests.
In this case, for example, the part we (probably) care about is that the class name (`RequiresNonEmptyList`) is displayed. (We can't really tell the difference between what we care about and what was accidentally included, but that's my guess.)
It would be nice to minimize the text being compared, but unless Paul or Konstantin cares I'm not going to stop the CL from landing because of it.
Felipe Morschel
Yes, I agree this is a bit weird. But this text was here before my changes. I simply moved it to the (now/new) single place that checks for the text. It was previously checking for the whole text (the only existing option), I'm deprecating the old `text` exactly because of this, so we can make these checks more specific to the changes we make.
I didn't change this because that would be yet again moving away from this CLs purpose. In a future change we can surely make this smaller.
Related details
Attention is currently required from:
- Paul Berry
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Sep 29, 2025, 6:06:08 PMSep 29
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Samuel Rawlins
Paul Berry voted and added 2 comments![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
2 comments
Patchset-level comments
File pkg/analyzer/test/src/diagnostics/inconsistent_language_version_override_test.dart
Line 77, Patchset 2 (Latest):
required List<ExpectedDiagnostic> libraryDiagnosticss,Paul Berry . unresolved
Should be `libraryDiagnostics`.
Related details
Attention is currently required from:
- Felipe Morschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Sep 29, 2025, 6:25:17 PMSep 29
to Paul Berry, Brian Wilkerson, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Paul Berry and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
1 comment
File pkg/analyzer/test/src/diagnostics/inconsistent_language_version_override_test.dart
Line 77, Patchset 2:
required List<ExpectedDiagnostic> libraryDiagnosticss,Paul Berry . resolved
Felipe MorschelShould be `libraryDiagnostics`.
Fix applied.
Related details
Attention is currently required from:
- Brian Wilkerson
- Paul Berry
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Sep 29, 2025, 6:26:16 PMSep 29
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
| Commit-Queue | +1 |
Paul Berry . resolved
lgtm
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Oct 17, 2025, 11:19:18 AM (4 days ago) Oct 17
to Felipe Morschel, Brian Wilkerson, Commit Queue, Paul Berry, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Samuel Rawlins
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
Patchset-level comments
Brian Wilkerson . resolved
Just found this in my backlog. The analyzer_testing and linter changes lgtm. I'm not sure whether there's still interest in landing this.
Related details
Attention is currently required from:
- Felipe Morschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Oct 17, 2025, 12:08:39 PM (4 days ago) Oct 17
to Brian Wilkerson, Commit Queue, Paul Berry, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Paul Berry and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
Brian Wilkerson . resolved
Just found this in my backlog. The analyzer_testing and linter changes lgtm. I'm not sure whether there's still interest in landing this.
Felipe Morschel
Yes, please!
I forgot this had not landed. Probably because I got two +1. I've just pushed a new patchset with the required rebase.
Thanks a lot!
Related details
Attention is currently required from:
- Brian Wilkerson
- Paul Berry
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Oct 17, 2025, 12:23:40 PM (4 days ago) Oct 17
to Felipe Morschel, Brian Wilkerson, Commit Queue, Paul Berry, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel, Paul Berry and Samuel Rawlins
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
Brian Wilkerson . resolved
Felipe MorschelJust found this in my backlog. The analyzer_testing and linter changes lgtm. I'm not sure whether there's still interest in landing this.
Yes, please!
I forgot this had not landed. Probably because I got two +1. I've just pushed a new patchset with the required rebase.
Thanks a lot!
Brian Wilkerson
Gerrit can show you a list of all the open CLs you have. It might be worthwhile looking those over.
Related details
Attention is currently required from:
- Felipe Morschel
- Paul Berry
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Oct 19, 2025, 10:20:53 PM (2 days ago) Oct 19
to Felipe Morschel, Brian Wilkerson, Commit Queue, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Samuel Rawlins
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
| Commit-Queue | +2 |
Paul Berry . resolved
lgtm
Attention is currently required from:
- Felipe Morschel
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Oct 20, 2025, 7:35:14 AM (yesterday) Oct 20
to Paul Berry, Brian Wilkerson, Commit Queue, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Paul Berry
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
Paul Berry . resolved
lgtm
Felipe Morschel
We had yet another reference to the old `ExpectedError` so I had to rebase and fix that. If we could land this soon we could probably avoid this again. Thanks!
Related details
Attention is currently required from:
- Brian Wilkerson
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Oct 20, 2025, 11:01:21 AM (yesterday) Oct 20
to Felipe Morschel, Brian Wilkerson, Paul Berry, Commit Queue, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Paul Berry
Brian Wilkerson voted![]( "Open in Gerrit")
Attention is currently required from:
- Felipe Morschel
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Oct 20, 2025, 4:36:49 PM (21 hours ago) Oct 20
to Felipe Morschel, Brian Wilkerson, Commit Queue, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
| Commit-Queue | +2 |
Paul Berry . resolved
lgtm
Related details
Attention is currently required from:
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Oct 20, 2025, 4:37:05 PM (21 hours ago) Oct 20
to Felipe Morschel, Paul Berry, Brian Wilkerson, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[analyzer] Migrates to `contexMessages` from `analyzer_testing` package
This also includes some small refactorings for parameter names to start using the diagnostic wording instead of error. As well as a small change to `contextMessage` and related to use a list of `Pattern`s instead of a single `String` for better matching.
In future CLs, the TODOs added in this one will be addressed so we can fully migrate this. Added them because of the size of the CL.
Change-Id: I5557668a1baed98faff977255c9f22e0d9d96008
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/452180
Commit-Queue: Paul Berry <paul...@google.com>
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analyzer/test/src/diagnostics/experimental_member_use_test.dart
- M pkg/analyzer/test/src/diagnostics/getter_not_subtype_setter_types_test.dart
- M pkg/analyzer/test/src/diagnostics/inconsistent_language_version_override_test.dart
- M pkg/analyzer/test/src/diagnostics/invalid_constant_test.dart
- M pkg/analyzer/test/src/diagnostics/mixin_subtype_of_base_is_not_base_test.dart
- M pkg/analyzer/test/src/diagnostics/mixin_subtype_of_final_is_not_base_test.dart
- M pkg/analyzer/test/src/diagnostics/not_assigned_potentially_non_nullable_local_variable_test.dart
- M pkg/analyzer/test/src/diagnostics/parser_diagnostics.dart
- M pkg/analyzer/test/src/diagnostics/sdk_constraint_verifier_support.dart
- M pkg/analyzer/test/src/diagnostics/sdk_version_gt_gt_gt_operator_test.dart
- M pkg/analyzer/test/src/diagnostics/sdk_version_since_test.dart
- M pkg/analyzer/test/src/diagnostics/subtype_of_base_is_not_base_final_or_sealed_test.dart
- M pkg/analyzer/test/src/diagnostics/subtype_of_final_is_not_base_final_or_sealed_test.dart
- M pkg/analyzer/test/src/diagnostics/use_of_void_result_test.dart
- M pkg/analyzer/test/src/fasta/recovery/result_comparator_test.dart
- M pkg/analyzer/test/src/options/options_file_validator_test.dart
- M pkg/analyzer/test/src/options/options_rule_validator_test.dart
- M pkg/analyzer/test/src/task/strong/inferred_type_test.dart
- M pkg/analyzer_testing/api.txt
- M pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart
- M pkg/analyzer_testing/lib/src/analysis_rule/pub_package_resolution.dart
- M pkg/linter/test/rules/conditional_uri_does_not_exist_test.dart
- M pkg/linter/test/rules/use_build_context_synchronously_test.dart
- M pkg/linter/test/rules/use_super_parameters_test.dart
Change size: XL
Delta: 56 files changed, 1406 insertions(+), 1106 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Paul Berry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages