[XL] Change in dart/sdk[main]: [benchmarks] Add some benchmarks to SDK

2 views

Skip to first unread message

unread,

Apr 13, 2022, 10:57:57 AM4/13/22

to Stephen Adams, rev...@dartlang.org, William Hesse, Alexander Thomas

Attention is currently required from: Stephen Adams, William Hesse.

Patch set 1:Code-Review +1

2 comments:

Patchset:
- Patch Set #1:
  Agreed on the copyrights headers needing to be corrected.
File benchmarks/CollectionSieves/dart/run.dart:
- Patch Set #1, Line 5:
```
// Copyright 2017 Google Inc. All Rights Reserved.
//
// Micro-benchmarks exercising core library data structures.
//
```
  I don't think it is right to have two copyright statements and dates, is it? […]
  Agreed.

To view, visit change 196440. To unsubscribe, or for help writing mail filters, visit settings.

unread,

May 13, 2022, 5:25:42 PM5/13/22

to Stephen Adams, rev...@dartlang.org, William Hesse, Alexander Thomas

Jonas Termansen abandoned this change.

Abandoned

Please resurrect this CL or let us know if you still have interest in having this work done :)

To view, visit change 196440. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages