Felipe Morschel (Gerrit)

unread,

Nov 21, 2025, 3:10:41 PM11/21/25

to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Adds support for using `TestCode` markers in `AnalysisRuleTest`

Bug: https://github.com/dart-lang/sdk/issues/61889

Change-Id: I8c12a2fa90eaee88f79f16308faf0b26c75c550b

Change information

Files:

M pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart
M pkg/analyzer_testing/lib/src/analysis_rule/pub_package_resolution.dart

Change size: M

Delta: 2 files changed, 153 insertions(+), 34 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

Nov 21, 2025, 4:14:13 PM11/21/25

to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Felipe Morschel and Samuel Rawlins

Brian Wilkerson added 1 comment

File pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart

Line 49, Patchset 1 (Latest): @Deprecated('Use textContains instead') String? text,

Brian Wilkerson . unresolved

Why are we declaring deprecated parameters in a newly added methods? Consider removing them so that there's no code to clean up later.

Open in Gerrit

Related details

Attention is currently required from:

Felipe Morschel
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Nov 24, 2025, 12:39:25 PM11/24/25

to Paul Berry, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Paul Berry and Samuel Rawlins

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

Auto-Submit

+1

1 comment

File pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart

Line 49, Patchset 1: @Deprecated('Use textContains instead') String? text,

Brian Wilkerson . unresolved

Why are we declaring deprecated parameters in a newly added methods? Consider removing them so that there's no code to clean up later.

Felipe Morschel

Great catch!

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Paul Berry
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Nov 24, 2025, 12:39:51 PM11/24/25

to Paul Berry, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Paul Berry and Samuel Rawlins

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

Auto-Submit

+1

1 comment

File pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart

Line 49, Patchset 1: @Deprecated('Use textContains instead') String? text,

Brian Wilkerson . resolved

Why are we declaring deprecated parameters in a newly added methods? Consider removing them so that there's no code to clean up later.

Felipe Morschel

Great catch!

Felipe Morschel

Forgot to check as resolved.

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Paul Berry
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

Nov 24, 2025, 2:45:56 PM11/24/25

to Felipe Morschel, Paul Berry, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Felipe Morschel and Paul Berry

Samuel Rawlins voted and added 6 comments

Votes added by Samuel Rawlins

Code-Review

+1

6 comments

File pkg/analyzer/test/generated/error_parser_test.dart

Line 9, Patchset 3 (Latest):import 'package:analyzer_testing/analysis_rule/analysis_rule.dart';

Samuel Rawlins . unresolved

Can you document in the CL description why all these new imports are needed?

File pkg/analyzer/test/generated/parser_test_base.dart

Line 1686, Patchset 3 (Parent): ExpectedError error(

Samuel Rawlins . unresolved

Why is this deleted? If this is intentional, please add it to the CL description.

File pkg/analyzer/test/src/options/options_file_validator_test.dart

Line 687, Patchset 3 (Parent): ExpectedError error(

Samuel Rawlins . unresolved

Was this dead code or did it get moved somewhere?

File pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart

Line 74, Patchset 3 (Latest): @Deprecated('Use messageContainsAll instead') Pattern? correctionContains,

Samuel Rawlins . unresolved

Should this say "Use correctionContainsAll"?

File pkg/analyzer_testing/lib/src/analysis_rule/pub_package_resolution.dart

Line 335, Patchset 3 (Latest): set parsedTestCode(TestCode value) {

Samuel Rawlins . unresolved

We don't usually comment on both the setter and the getter; dartdoc will document both with the getter's comment. Is there a reason to specially document each here (with the same text)?

Line 349, Patchset 3 (Latest): set testCode(String value) {

Samuel Rawlins . unresolved

Since this is a setter, I would expect the doc comment to read with a verb like "Sets the raw..."

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Felipe Morschel
Paul Berry

Submit Requirements:

Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Nov 24, 2025, 2:56:27 PM11/24/25

to Commit Queue, Samuel Rawlins, Paul Berry, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Paul Berry and Samuel Rawlins

Felipe Morschel voted and added 6 comments

Votes added by Felipe Morschel

Auto-Submit

+1

6 comments

File pkg/analyzer/test/generated/error_parser_test.dart

Line 9, Patchset 3:import 'package:analyzer_testing/analysis_rule/analysis_rule.dart';

Samuel Rawlins . resolved

Can you document in the CL description why all these new imports are needed?

Felipe Morschel

Sure. TLDR: I removed the `error` methods from the specific classes there and imported the same one everwhere that method was not available.

File pkg/analyzer/test/generated/parser_test_base.dart

Line 1686, Patchset 3 (Parent): ExpectedError error(

Samuel Rawlins . resolved

Why is this deleted? If this is intentional, please add it to the CL description.

Felipe Morschel

Deleted. This is explained at https://dart-review.googlesource.com/c/sdk/+/463840/comment/2eb42ba5_370435d3/ and the CL desciption.

File pkg/analyzer/test/src/options/options_file_validator_test.dart

Line 687, Patchset 3 (Parent): ExpectedError error(

Samuel Rawlins . resolved

Was this dead code or did it get moved somewhere?

Felipe Morschel

Deleted. This is explained at https://dart-review.googlesource.com/c/sdk/+/463840/comment/2eb42ba5_370435d3/ and the CL desciption.

File pkg/analyzer_testing/lib/analysis_rule/analysis_rule.dart

Line 74, Patchset 3: @Deprecated('Use messageContainsAll instead') Pattern? correctionContains,

Samuel Rawlins . resolved

Should this say "Use correctionContainsAll"?

Felipe Morschel

Great catch! Thanks!

File pkg/analyzer_testing/lib/src/analysis_rule/pub_package_resolution.dart

Line 335, Patchset 3: set parsedTestCode(TestCode value) {

Samuel Rawlins . resolved

We don't usually comment on both the setter and the getter; dartdoc will document both with the getter's comment. Is there a reason to specially document each here (with the same text)?

Felipe Morschel

I wasn't aware of that. Thanks!

Line 349, Patchset 3: set testCode(String value) {

Samuel Rawlins . resolved

Since this is a setter, I would expect the doc comment to read with a verb like "Sets the raw..."

Felipe Morschel

Done

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Paul Berry
Samuel Rawlins

Submit Requirements:

Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

Nov 24, 2025, 4:04:30 PM11/24/25

to Felipe Morschel, Brian Wilkerson, Commit Queue, Samuel Rawlins, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Felipe Morschel, Paul Berry and Samuel Rawlins

Brian Wilkerson voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Felipe Morschel
Paul Berry
Samuel Rawlins

Submit Requirements:

Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

Nov 24, 2025, 5:17:56 PM11/24/25

to Felipe Morschel, Brian Wilkerson, Commit Queue, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Felipe Morschel and Paul Berry

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Samuel Rawlins . resolved

Thanks for the explanations!

Open in Gerrit

Related details

Attention is currently required from:

Felipe Morschel
Paul Berry

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

Nov 24, 2025, 5:18:53 PM11/24/25

to Felipe Morschel, Brian Wilkerson, Commit Queue, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Felipe Morschel, Paul Berry and Samuel Rawlins

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Samuel Rawlins . resolved

Oh if you want to document TestCode APIs, either in pkg/analysis_server_plugin/doc, or somewhere in pkg/analyzer_testing, that would be wonderful; otherwise someone on the team probably can.

Open in Gerrit

Related details

Attention is currently required from:

Felipe Morschel
Paul Berry
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Nov 24, 2025, 5:20:23 PM11/24/25

to Samuel Rawlins, Brian Wilkerson, Commit Queue, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Paul Berry and Samuel Rawlins

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Samuel Rawlins . resolved

Oh if you want to document TestCode APIs, either in pkg/analysis_server_plugin/doc, or somewhere in pkg/analyzer_testing, that would be wonderful; otherwise someone on the team probably can.

Felipe Morschel

I'll open a follow up CL for this then. Good idea!

Open in Gerrit

Related details

Attention is currently required from:

Paul Berry
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Paul Berry (Gerrit)

unread,

Nov 24, 2025, 6:31:00 PM11/24/25

to Felipe Morschel, Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Felipe Morschel and Samuel Rawlins

Paul Berry voted and added 1 comment

Votes added by Paul Berry

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Paul Berry . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

Felipe Morschel
Samuel Rawlins

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Nov 24, 2025, 7:48:01 PM11/24/25

to Paul Berry, Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Paul Berry and Samuel Rawlins

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5:

Felipe Morschel . unresolved

I'm sorry. I'm not familiar with these files. How can I edit them to make the bots pass?
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8697277265645935537/+/u/test_results/new_test_failures

---

Also, I've asked a question about this API on the issue: https://github.com/dart-lang/sdk/issues/61889#issuecomment-3573293513

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Paul Berry
Samuel Rawlins

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Nov 24, 2025, 7:51:06 PM11/24/25

to Paul Berry, Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Paul Berry and Samuel Rawlins

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5:

Felipe Morschel . unresolved

I'm sorry. I'm not familiar with these files. How can I edit them to make the bots pass?
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8697277265645935537/+/u/test_results/new_test_failures
---
Also, I've asked a question about this API on the issue: https://github.com/dart-lang/sdk/issues/61889#issuecomment-3573293513

Felipe Morschel

A better question would probably be: how did I break those?

Here is the full failure https://ci.chromium.org/ui/p/dart/builders/try/analyzer-linux-release-try/96555/overview

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Paul Berry
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

Nov 24, 2025, 8:40:50 PM11/24/25

to Felipe Morschel, Paul Berry, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Felipe Morschel and Paul Berry

Samuel Rawlins voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Felipe Morschel
Paul Berry

Submit Requirements:

Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Nov 25, 2025, 5:48:36 AM11/25/25

to Samuel Rawlins, Paul Berry, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson and Paul Berry

Felipe Morschel added 1 comment

Patchset-level comments

File-level comment, Patchset 5:

Felipe Morschel . unresolved

I'm sorry. I'm not familiar with these files. How can I edit them to make the bots pass?
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8697277265645935537/+/u/test_results/new_test_failures
---
Also, I've asked a question about this API on the issue: https://github.com/dart-lang/sdk/issues/61889#issuecomment-3573293513

Felipe Morschel

A better question would probably be: how did I break those?
Here is the full failure https://ci.chromium.org/ui/p/dart/builders/try/analyzer-linux-release-try/96555/overview

Felipe Morschel

Okay, so it seems I didn't break those ones. Thanks for the bots!

Would you mind taking a look at my question on the issue @sraw...@google.com and @brianwi...@google.com? Thanks! (Feel free to hop over too Paul, I'm just not entirely sure you are interested)

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Paul Berry

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

Dec 10, 2025, 1:28:27 PM12/10/25

to Felipe Morschel, Samuel Rawlins, Paul Berry, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Felipe Morschel and Paul Berry

Brian Wilkerson added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Brian Wilkerson . resolved

Is this something you still want to push forward on, or are you still waiting on an answer from us?

Open in Gerrit

Related details

Attention is currently required from:

Felipe Morschel
Paul Berry

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Dec 10, 2025, 1:38:12 PM12/10/25

to Samuel Rawlins, Paul Berry, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson

Felipe Morschel added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Brian Wilkerson . resolved

Is this something you still want to push forward on, or are you still waiting on an answer from us?

Felipe Morschel

Yes I do. I'll probably take a look at this tomorrow, thanks for the reminder.

From the issue discussion, the `fooFromRange` methods/functions might not be the best path forward. So I'll probably leave this "usage" part for a second CL so this doesn't get too big.

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[M] Change in dart/sdk[main]: [DAS] Adds support for using `TestCode` markers in `AnalysisRuleTest`

Felipe Morschel (Gerrit)

Felipe Morschel has uploaded the change for review

Commit message

Change information

Related details

Brian Wilkerson (Gerrit)

Brian Wilkerson added 1 comment

Related details

Felipe Morschel (Gerrit)

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

1 comment

Related details

Felipe Morschel (Gerrit)

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

1 comment

Related details

Samuel Rawlins (Gerrit)

Samuel Rawlins voted and added 6 comments

Votes added by Samuel Rawlins

6 comments

Related details

Felipe Morschel (Gerrit)

Felipe Morschel voted and added 6 comments

Votes added by Felipe Morschel

6 comments

Related details

Brian Wilkerson (Gerrit)

Brian Wilkerson voted Code-Review+1

Related details

Samuel Rawlins (Gerrit)

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

1 comment

Related details

Samuel Rawlins (Gerrit)

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

1 comment

Related details

Felipe Morschel (Gerrit)

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

1 comment

Related details

Paul Berry (Gerrit)

Paul Berry voted and added 1 comment

Votes added by Paul Berry

1 comment

Related details

Felipe Morschel (Gerrit)

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

1 comment

Related details

Felipe Morschel (Gerrit)

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

1 comment

Related details

Samuel Rawlins (Gerrit)

Samuel Rawlins voted Code-Review+1

Related details

Felipe Morschel (Gerrit)

Felipe Morschel added 1 comment

Related details

Brian Wilkerson (Gerrit)

Brian Wilkerson added 1 comment

Related details

Felipe Morschel (Gerrit)

Felipe Morschel added 1 comment

Related details