[M] Change in dart/sdk[main]: [build] Put sanitizer versions of the AOT runtime into the SDK for te...

0 views
Skip to first unread message

Ryan Macnak (Gerrit)

unread,
Dec 1, 2025, 3:55:00 PM (yesterday) Dec 1
to Alexander Aprelev, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Aprelev

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Aprelev
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I25485e27331a0b8724e954a5222a11a1db45cfb7
Gerrit-Change-Number: 464623
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Alexander Aprelev <a...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 20:54:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Aprelev (Gerrit)

unread,
Dec 1, 2025, 4:15:34 PM (yesterday) Dec 1
to Ryan Macnak, Alexander Aprelev, Commit Queue, rev...@dartlang.org
Attention needed from Ryan Macnak

Alexander Aprelev voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Macnak
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I25485e27331a0b8724e954a5222a11a1db45cfb7
Gerrit-Change-Number: 464623
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 21:15:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ryan Macnak (Gerrit)

unread,
Dec 1, 2025, 5:22:13 PM (23 hours ago) Dec 1
to Alexander Aprelev, Commit Queue, rev...@dartlang.org

Ryan Macnak voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I25485e27331a0b8724e954a5222a11a1db45cfb7
Gerrit-Change-Number: 464623
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 22:22:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 1, 2025, 6:06:57 PM (23 hours ago) Dec 1
to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[build] Put sanitizer versions of the AOT runtime into the SDK for testing.

Note there is no need for versions of gen_snapshot because the sanitizer target is a runtime flag.
Change-Id: I25485e27331a0b8724e954a5222a11a1db45cfb7
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Files:
  • M build/config/sysroot.gni
  • M build/toolchain/toolchain_suite.gni
  • M sdk/BUILD.gn
Change size: M
Delta: 3 files changed, 63 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alexander Aprelev
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I25485e27331a0b8724e954a5222a11a1db45cfb7
Gerrit-Change-Number: 464623
Gerrit-PatchSet: 2
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages