[XL] Change in dart/sdk[main]: [dyn_modules] Support types in a dynamic interface.
Sigmund Cherem (Gerrit)
Sigmund Cherem added 2 comments![]( "Open in Gerrit")
static const String canBeUsedAsTypePragmaName =Note: we are not using this yet, so we can wait to add this until we need it. Thoughts: are there any entities in the SDK we currently label as callable that we may want to label as `can-be-used-as-type` instead?
(pragma_name != Symbols::dyn_module_can_be_used_as_type().ptr())) {I have less familiarity here, so I'm not sure if this is the right change. Without this, end-to-end tests pass in debug-mode but crash in release-mode.
Related details
- Alexander Markov
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Johnni Winther voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johnni Winther
| Code-Review | +1 |
1 comment
void testCanBeUsedAsType(Object? o) {Add tests for types that are inferred. For instance if you allow `B` and `C` but not `A` in
class A {}
class B extends A {}
class C extends A {}
then the inferred type `A` in this should be flagged:var list = [B(), C()];
Related details
- Alexander Markov
- Sigmund Cherem
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Alexander Markov added 3 comments![]( "Open in Gerrit")
"'implicitly-extendable', or 'can-be-used-as-type'.\n"We don't support these values in the entry-point pragmas, so the updated message is misleading.
"'call', or 'can-be-used-as-type'.\n"ditto
(pragma_name != Symbols::dyn_module_can_be_used_as_type().ptr())) {I have less familiarity here, so I'm not sure if this is the right change. Without this, end-to-end tests pass in debug-mode but crash in release-mode.
This makes `dyn-module:can-be-used-as-type` pragma behave pretty much like `dyn-module:callable`, i.e. VM would treat annotated class as instantiated. I think we need a proper implementation in the VM - see uses of this function.
Related details
- Sigmund Cherem
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |