[M] Change in dart/sdk[main]: [modular_aot] Avoid generating code for instance members of mixins
0 views
Skip to first unread message
Alexander Markov (Gerrit)
Apr 21, 2026, 5:34:31 PM (18 hours ago) Apr 21
to Alexander Markov, Slava Egorov, Nate Biggs, Tess Strickland, Alexander Aprelev, Nicholas Shahan, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Slava Egorov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
3:36 AM (8 hours ago) 3:36 AM
to Alexander Markov, Nate Biggs, Tess Strickland, Alexander Aprelev, Nicholas Shahan, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Alexander Markov
Slava Egorov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
9:30 AM (2 hours ago) 9:30 AM
to Alexander Markov, Slava Egorov, Nate Biggs, Tess Strickland, Alexander Aprelev, Nicholas Shahan, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Alexander Markov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
9:30 AM (2 hours ago) 9:30 AM
to Alexander Markov, Slava Egorov, Nate Biggs, Tess Strickland, Alexander Aprelev, Nicholas Shahan, Stephen Adams, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[modular_aot] Avoid generating code for instance members of mixins
After mixin transformation, original members of mixins should not be
called. Only their clones in the mixin application classes can be
called.
By removing their bodies we can reduce code size and avoid any
complexity related to super-invocations of abstract members.
Change-Id: I0ae1bbac6e4c82356841fdc870bfd8ca1bac8fb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/497102
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
- M pkg/cfg/lib/front_end/ast_to_ir.dart
- M pkg/cfg/lib/ir/flow_graph_builder.dart
- M pkg/cfg/lib/ir/flow_graph_checker.dart
- M pkg/cfg/lib/ir/instructions.dart
- M pkg/cfg/lib/ir/visitor.dart
- M pkg/cfg/lib/passes/constant_propagation.dart
- M pkg/cfg/lib/passes/simplification.dart
- M pkg/cfg/testcases/calls.dart
- M pkg/cfg/testcases/calls.dart.expect
- M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
- M pkg/native_compiler/lib/back_end/constraints.dart
- M pkg/native_compiler/lib/passes/reorder_blocks.dart
Change size: M
Delta: 12 files changed, 179 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Slava Egorov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages