[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. I.

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
5:28 AM (4 hours ago) 5:28 AM
to Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry

Johnni Winther voted and added 3 comments

Votes added by Johnni Winther

Code-Review+1

3 comments

File pkg/analyzer/test/src/diagnostics/integer_literal_imprecise_as_double_test.dart
Line 30, Patchset 3 (Parent): // We suggest the max double instead.
'1797693134862315708145274237317043567980705675258449965989174768'
'0315726078002853876058955863276687817154045895351438246423432132'
'6889464182768467546703537516986049910576551282076245490090389328'
'9440758685084551339423045832369032229481658085593321233482747978'
'26204144723168738177180919299881250404026184124858368',
),
Johnni Winther . unresolved

Add this as a comment. If we add correction messages we can verify this again.

Line 52, Patchset 3 (Parent): correctionContains: '9223372036854775808',
Johnni Winther . unresolved

Ditto.

Line 71, Patchset 3 (Parent): correctionContains: '9223372036854775808',
Johnni Winther . unresolved

Ditto.

Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
  • Paul Berry
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I47dd3fb3f6126047c4f5bec5a84be64cdbbf7261
Gerrit-Change-Number: 502720
Gerrit-PatchSet: 3
Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 09:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages