[M] Change in dart/sdk[main]: Update RenameExtensionMethod to use a ChangeBuilder
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
9:53 AM (11 hours ago) 9:53 AM
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
9:59 AM (11 hours ago) 9:59 AM
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
10:48 AM (10 hours ago) 10:48 AM
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
10:48 AM (10 hours ago) 10:48 AM
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Update RenameExtensionMethod to use a ChangeBuilder
Another step toward converting all of the legacy refactors to use a
ChangeBuilder rather than creating source edits directly.
Change-Id: I117cb2e71d7832fbec3e23b63228a248f75cdcd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491520
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/rename.dart
- M pkg/analysis_server/lib/src/services/refactoring/legacy/rename_extension_member.dart
Change size: M
Delta: 3 files changed, 164 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages