[L] Change in dart/sdk[main]: [ SDK ] Add `js_dev_runtime` stubs for `dart:ffi`
0 views
Skip to first unread message
Ben Konyi (Gerrit)
Dec 10, 2025, 1:16:32 PM12/10/25
to Nicholas Shahan, Daco Harkes, Johnni Winther, Commit Queue, Mark Zhou, Nate Biggs, Sigmund Cherem, dart2js-te...@google.com, dart-dc-te...@google.com, rev...@dartlang.org
Attention needed from Daco Harkes, Johnni Winther, Mark Zhou and Sigmund Cherem
Ben Konyi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 11 (Latest):
Ben Konyi . resolved
@mark...@google.com, the DDC side of this should be ready for review (although, I'm not sure why `pkg/dev_compiler/test/sdk_source_map_test` is failing as it does pass locally).
Related details
Attention is currently required from:
- Daco Harkes
- Johnni Winther
- Mark Zhou
- Sigmund Cherem
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Zhou (Gerrit)
Dec 10, 2025, 1:58:38 PM12/10/25
to Ben Konyi, Nicholas Shahan, Daco Harkes, Johnni Winther, Commit Queue, Nate Biggs, Sigmund Cherem, dart2js-te...@google.com, dart-dc-te...@google.com, rev...@dartlang.org
Attention needed from Ben Konyi, Daco Harkes, Johnni Winther and Sigmund Cherem
Mark Zhou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Zhou
| Code-Review | +1 |
1 comment
Patchset-level comments
Mark Zhou . resolved
DDC-side change LGTM - but I'm also not sure why that test is failing.
Related details
Attention is currently required from:
- Ben Konyi
- Daco Harkes
- Johnni Winther
- Sigmund Cherem
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Dec 11, 2025, 5:14:08 AM12/11/25
to Ben Konyi, Mark Zhou, Nicholas Shahan, Daco Harkes, Commit Queue, Nate Biggs, Sigmund Cherem, dart2js-te...@google.com, dart-dc-te...@google.com, rev...@dartlang.org
Attention needed from Ben Konyi, Daco Harkes, Mark Zhou and Sigmund Cherem
Johnni Winther added 1 comment![]( "Open in Gerrit")
File sdk/lib/ffi/ffi.dart
Line 525, Patchset 6:
external bool get keepIsolateAlive;Ben Konyi . unresolved
Daco Harkes@dacoh...@google.com, I wasn't able to get this to work without adding explicit getters and setters as the patching mechanism doesn't seem to like patching properties with implicit getters and setters.
Johnni Winthercc @johnni...@google.com, I believe you would want to know if augmentations with fields doesn't work as expected. Are the patchfiles already working with the augmentations implementation?
@bko...@google.com lgtm to work around a patching issue like that. The language spec says a field is identical to a getter and setter from an API POV.
The current patching mechanism doesn't support patching of fields. When we get further into the implementation for augmentations I think it should be possible (pending the exact spec for field augmentation which).
Related details
Attention is currently required from:
- Ben Konyi
- Daco Harkes
- Mark Zhou
- Sigmund Cherem
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Shahan (Gerrit)
Dec 16, 2025, 2:06:42 PM12/16/25
to Ben Konyi, Mark Zhou, Daco Harkes, Johnni Winther, Commit Queue, Nate Biggs, Sigmund Cherem, dart2js-te...@google.com, dart-dc-te...@google.com, rev...@dartlang.org
Attention needed from Ben Konyi, Daco Harkes, Mark Zhou and Sigmund Cherem
Nicholas Shahan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ben Konyi
- Daco Harkes
- Mark Zhou
- Sigmund Cherem
Submit Requirements:
Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
Dec 17, 2025, 11:51:59 AM12/17/25
to Nicholas Shahan, Mark Zhou, Daco Harkes, Johnni Winther, Commit Queue, Nate Biggs, Sigmund Cherem, dart2js-te...@google.com, dart-dc-te...@google.com, rev...@dartlang.org
Attention needed from Daco Harkes, Mark Zhou and Sigmund Cherem
Ben Konyi voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
Commit Queue (Gerrit)
Dec 17, 2025, 12:26:17 PM12/17/25
to Ben Konyi, Nicholas Shahan, Mark Zhou, Daco Harkes, Johnni Winther, Nate Biggs, Sigmund Cherem, dart2js-te...@google.com, dart-dc-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ SDK ] Add `js_dev_runtime` stubs for `dart:ffi`
This will allow for developer tooling to still compile applications with
`dart:ffi` imports for web targets.
Fixes https://github.com/dart-lang/sdk/issues/62126
CoreLibraryReviewExempt: Not changing implementations, just adding stubs
Change-Id: I7347dc81c8bffe0becaf4b1d002d6aca2de60244
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/464960
Commit-Queue: Ben Konyi <bko...@google.com>
Reviewed-by: Nicholas Shahan <nsh...@google.com>
Files:
- M pkg/dev_compiler/lib/src/kernel/target.dart
- M pkg/dev_compiler/test/expression_compiler/expression_compiler_test.dart
- A sdk/lib/_internal/js_dev_runtime/patch/ffi_patch.dart
- M sdk/lib/ffi/ffi.dart
- M sdk/lib/libraries.json
- M sdk/lib/libraries.yaml
Change size: L
Delta: 6 files changed, 876 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nicholas Shahan
Core-Library-Review: Code-Review+1 by Nicholas Shahan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages