[M] Change in dart/sdk[main]: [DAS] Use named super parameters in a few missed cases.
0 views
Skip to first unread message
Samuel Rawlins (Gerrit)
9:57 AM (11 hours ago) 9:57 AM
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
10:58 AM (10 hours ago) 10:58 AM
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
11:01 AM (10 hours ago) 11:01 AM
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
11:01 AM (10 hours ago) 11:01 AM
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[DAS] Use named super parameters in a few missed cases.
Work towards https://github.com/dart-lang/sdk/issues/58729.
The lint rule will suggest using a super-parameter for a named parameter even if the positional parameters cannot be super-parameters.
Change-Id: I943b045c37336c196a59b4041537ac47b0ee68d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491500
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analysis_server/tool/spec/api.dart
Change size: M
Delta: 1 file changed, 39 insertions(+), 39 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages