[M] Change in dart/sdk[main]: [DAS] Makes `AbstractContextTest.createAnalysisOptionsFile` like `ana...

[Felipe Morschel (Gerrit)]

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Makes `AbstractContextTest.createAnalysisOptionsFile` like `analysisOptionsContent`

This change is only meant to improve consistency and readability in the test code. The `analysisOptionsContent` function had more parameters and now both take the same things. Also, `createAnalysisOptionsFile` now doesn't implement the same behaviour as `analysisOptionsContent` because it simply invokes it instead.

Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Change information

Files:

• M pkg/analysis_server/test/abstract_context.dart
• M pkg/analysis_server/test/services/correction/sort_members_test.dart
• M pkg/analyzer_testing/lib/utilities/utilities.dart

Change size: M

Delta: 3 files changed, 28 insertions(+), 42 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 1

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

[Samuel Rawlins (Gerrit)]

Attention needed from Brian Wilkerson and Felipe Morschel

Samuel Rawlins voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Felipe Morschel

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 1

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Comment-Date: Wed, 13 Aug 2025 18:07:10 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Brian Wilkerson (Gerrit)]

Attention needed from Felipe Morschel and Samuel Rawlins

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review

+1

1 comment

File pkg/analyzer_testing/lib/utilities/utilities.dart

Line 12, Patchset 2 (Latest): Map<String, Object?> errors = const {},

Brian Wilkerson . unresolved

Could this be `String`? It isn't critical to landing this, but I think they always have to be strings, so we might as well make it explicit.

Open in Gerrit

Related details

Attention is currently required from:

• Felipe Morschel
• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 2

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Tue, 19 Aug 2025 18:37:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Felipe Morschel (Gerrit)]

Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

Auto-Submit

+1

1 comment

File pkg/analyzer_testing/lib/utilities/utilities.dart

Line 12, Patchset 2 (Latest): Map<String, Object?> errors = const {},

Brian Wilkerson . unresolved

Could this be `String`? It isn't critical to landing this, but I think they always have to be strings, so we might as well make it explicit.

Felipe Morschel

Tecnically everything in a file is a String, yes, but we can write things like `annotate_overrides: false` where `false` is actually a `bool` and not a String. I'm fine with changing it, but asking to be sure.

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 2

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Comment-Date: Tue, 19 Aug 2025 19:02:46 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>

[Brian Wilkerson (Gerrit)]

Attention needed from Felipe Morschel and Samuel Rawlins

Brian Wilkerson added 1 comment

File pkg/analyzer_testing/lib/utilities/utilities.dart

Line 12, Patchset 2 (Latest): Map<String, Object?> errors = const {},

Brian Wilkerson . unresolved

Could this be `String`? It isn't critical to landing this, but I think they always have to be strings, so we might as well make it explicit.

Felipe Morschel

Tecnically everything in a file is a String, yes, but we can write things like `annotate_overrides: false` where `false` is actually a `bool` and not a String. I'm fine with changing it, but asking to be sure.

Brian Wilkerson

The question is, is there any value, in test code, of writing
```dart
analysisOptionsContent(errors: {'annotate_overrides': false});
```
rather than
```dart
analysisOptionsContent(errors: {'annotate_overrides': 'false'});
```
given that there's effectively no type checking either way? (And that we're using `toString` rather than being smart about the output, which means that lists and maps can't be safely passed in.)

But given that this is test code, I suppose it doesn't matter much anyway, so I'll leave it to you to decide.

Open in Gerrit

Related details

Attention is currently required from:

• Felipe Morschel
• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 2

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Tue, 19 Aug 2025 21:47:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Felipe Morschel <g...@fmorschel.dev>

Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>

[Felipe Morschel (Gerrit)]

Attention needed from Samuel Rawlins

Felipe Morschel added 1 comment

File pkg/analyzer_testing/lib/utilities/utilities.dart

Line 12, Patchset 2 (Latest): Map<String, Object?> errors = const {},

Brian Wilkerson . resolved

Could this be `String`? It isn't critical to landing this, but I think they always have to be strings, so we might as well make it explicit.

Felipe Morschel

Tecnically everything in a file is a String, yes, but we can write things like `annotate_overrides: false` where `false` is actually a `bool` and not a String. I'm fine with changing it, but asking to be sure.

Brian Wilkerson

The question is, is there any value, in test code, of writing
```dart
analysisOptionsContent(errors: {'annotate_overrides': false});
```
rather than
```dart
analysisOptionsContent(errors: {'annotate_overrides': 'false'});
```
given that there's effectively no type checking either way? (And that we're using `toString` rather than being smart about the output, which means that lists and maps can't be safely passed in.)

But given that this is test code, I suppose it doesn't matter much anyway, so I'll leave it to you to decide.

Felipe Morschel

Well, I guess we can leave this as is. I suppose that `String.toString()` is probably really smart and any other cases being handled internally by the method should be easier for us to call it. I'll mark this as resolved but if we ever want to change this in the future the change should be a fairly small CL anyway. Thanks for the discussion.

Open in Gerrit

Related details

Attention is currently required from:

• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 2

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Tue, 19 Aug 2025 22:01:56 +0000

[Felipe Morschel (Gerrit)]

Attention needed from Samuel Rawlins

Felipe Morschel added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Felipe Morschel . unresolved

Can I get a review here please? Firendly ping @sraw...@google.com. Thanks a lot!

Open in Gerrit

Related details

Attention is currently required from:

• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 2

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Mon, 22 Sep 2025 18:08:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Samuel Rawlins (Gerrit)]

Attention needed from Felipe Morschel

Samuel Rawlins voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Felipe Morschel

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 2

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Comment-Date: Mon, 22 Sep 2025 21:58:49 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Felipe Morschel (Gerrit)]

Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2:

Felipe Morschel . unresolved

Can I get a review here please? Firendly ping @sraw...@google.com. Thanks a lot!

Felipe Morschel

I've fixed the broken tests (missing condition to add `analyzer` keyword). Ran all of the broken files locally, things are working now. Thanks for the bots!

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 2

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Tue, 23 Sep 2025 00:48:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Felipe Morschel <g...@fmorschel.dev>

[Samuel Rawlins (Gerrit)]

Attention needed from Brian Wilkerson and Felipe Morschel

Samuel Rawlins voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Felipe Morschel

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 3

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Comment-Date: Tue, 23 Sep 2025 00:56:58 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Felipe Morschel (Gerrit)]

Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel voted and added 1 comment

Votes added by Felipe Morschel

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2:

Felipe Morschel . unresolved

Can I get a review here please? Firendly ping @sraw...@google.com. Thanks a lot!

Felipe Morschel

I've fixed the broken tests (missing condition to add `analyzer` keyword). Ran all of the broken files locally, things are working now. Thanks for the bots!

Felipe Morschel

I've tried rebasing (using Gerrit UI) to see if the g3 bot passes now.

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 4

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Tue, 23 Sep 2025 13:33:52 +0000

[Samuel Rawlins (Gerrit)]

Attention needed from Brian Wilkerson and Felipe Morschel

Samuel Rawlins voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Felipe Morschel

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 4

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Comment-Date: Tue, 23 Sep 2025 14:28:29 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Brian Wilkerson (Gerrit)]

Attention needed from Felipe Morschel

Brian Wilkerson voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

• Felipe Morschel

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 4

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Comment-Date: Fri, 26 Sep 2025 17:54:11 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Commit Queue (Gerrit)]

Commit Queue submitted the change

Change information

Commit message:

[DAS] Makes `AbstractContextTest.createAnalysisOptionsFile` like `analysisOptionsContent`

This change is only meant to improve consistency and readability in the test code. The `analysisOptionsContent` function had more parameters and now both take the same things. Also, `createAnalysisOptionsFile` now doesn't implement the same behaviour as `analysisOptionsContent` because it simply invokes it instead.

Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445100

Reviewed-by: Samuel Rawlins <sraw...@google.com>

Reviewed-by: Brian Wilkerson <brianwi...@google.com>

Commit-Queue: Brian Wilkerson <brianwi...@google.com>

Auto-Submit: Felipe Morschel <g...@fmorschel.dev>

Files:

• M pkg/analysis_server/test/abstract_context.dart
• M pkg/analysis_server/test/services/correction/sort_members_test.dart
• M pkg/analysis_server/test/src/services/correction/fix/ignore_diagnostic_test.dart
• M pkg/analyzer_testing/api.txt
• M pkg/analyzer_testing/lib/utilities/utilities.dart

Change size: M

Delta: 5 files changed, 61 insertions(+), 56 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Samuel Rawlins, +1 by Brian Wilkerson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ie84f30f4affc1fb106598d636cd6fcf263e6520e

Gerrit-Change-Number: 445100

Gerrit-PatchSet: 5

Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>