[L] Change in dart/sdk[main]: [CQ] Use removeKeyword in place of removeAwait
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Mar 7, 2026, 5:36:18 PM (2 days ago) Mar 7
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Mar 7, 2026, 8:22:30 PM (2 days ago) Mar 7
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved
Fantastic! Very nice, I hope there are more possibilities like this.
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Mar 8, 2026, 10:36:47 AM (2 days ago) Mar 8
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 8, 2026, 10:37:09 AM (2 days ago) Mar 8
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[CQ] Use removeKeyword in place of removeAwait
This replaces the removeAwait correction producer with the awaitKeyword
producer.
The tests were moved to their new location. The test methods were not
changed, but the classes were renamed to be more appropriate.
In the process I noticed a performance improvement I could make to the
replaceKeyword producer, so I included that change here.
Change-Id: Ibff1e61762fa6d4d750d39f130d23681fee766ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/486400
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Files:
- D pkg/analysis_server/lib/src/services/correction/dart/remove_await.dart
- M pkg/analysis_server/lib/src/services/correction/dart/remove_keyword.dart
- M pkg/analysis_server/lib/src/services/correction/fix_internal.dart
- D pkg/analysis_server/test/src/services/correction/fix/remove_await_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/remove_keyword_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/test_all.dart
Change size: L
Delta: 6 files changed, 134 insertions(+), 185 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages