[M] Change in dart/sdk[main]: [analyzer] Stop using Diagnostic.data and deprecate it.
0 views
Skip to first unread message
Paul Berry (Gerrit)
Aug 10, 2025, 8:15:14 AM8/10/25
to Brian Wilkerson, Konstantin Shcheglov, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Johnni Winther and Konstantin Shcheglov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Brian Wilkerson
- Johnni Winther
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Aug 11, 2025, 3:50:37 AM8/11/25
to Paul Berry, Brian Wilkerson, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Konstantin Shcheglov and Paul Berry
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Aug 11, 2025, 12:24:54 PM8/11/25
to Paul Berry, Johnni Winther, Brian Wilkerson, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Konstantin Shcheglov and Paul Berry
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Aug 11, 2025, 12:29:41 PM8/11/25
to Paul Berry, Samuel Rawlins, Johnni Winther, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Paul Berry
Konstantin Shcheglov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Konstantin Shcheglov
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Konstantin Shcheglov . resolved
Well, we never get to serializing this data, so it is easier indeed to store it outside.
Related details
Attention is currently required from:
- Brian Wilkerson
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Aug 11, 2025, 5:54:05 PM8/11/25
to Konstantin Shcheglov, Samuel Rawlins, Johnni Winther, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Paul Berry voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Aug 11, 2025, 6:18:21 PM8/11/25
to Paul Berry, Konstantin Shcheglov, Samuel Rawlins, Johnni Winther, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[analyzer] Stop using Diagnostic.data and deprecate it.
The only two uses of `Diagnostic.data` have been replaced with
expandos keyed off the `Diagnostic` object. To make this possible, the
`at...` methods of `DiagnosticReporter` have been changed to return
the `Diagnostic` object they create. This paves the way for a future
CL series, in which I plan to change the API for reporting errors to a
more literate API in which the caller will have access to the
`Diagnostic` object.
Change-Id: I40820387abcd53daf934974c93106803d706fe07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444461
Commit-Queue: Paul Berry <paul...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/correction/dart/add_missing_switch_cases.dart
- M pkg/analysis_server/lib/src/services/correction/fix/pubspec/fix_generator.dart
- M pkg/analyzer/CHANGELOG.md
- M pkg/analyzer/api.txt
- M pkg/analyzer/lib/diagnostic/diagnostic.dart
- M pkg/analyzer/lib/error/listener.dart
- M pkg/analyzer/lib/src/dart/constant/constant_verifier.dart
- M pkg/analyzer/lib/src/error/literal_element_verifier.dart
- M pkg/analyzer/lib/src/generated/exhaustiveness.dart
- M pkg/analyzer/lib/src/pubspec/pubspec_validator.dart
- M pkg/analyzer/lib/src/pubspec/validators/missing_dependency_validator.dart
- M pkg/analyzer/test/src/pubspec/diagnostics/missing_dependency_test.dart
Change size: M
Delta: 12 files changed, 112 insertions(+), 62 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov, +1 by Johnni Winther, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages