[S] Change in dart/sdk[main]: [vm] Fix msvc build
0 views
Skip to first unread message
Alexander Markov (Gerrit)
Aug 8, 2025, 10:58:22 AMAug 8
to Alexander Markov, Alexander Aprelev, Ryan Macnak, Commit Queue, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Aug 8, 2025, 11:26:09 AMAug 8
to Alexander Markov, Alexander Aprelev, Ryan Macnak, Commit Queue, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
Alexander Aprelev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Aug 8, 2025, 11:27:07 AMAug 8
to Alexander Markov, Alexander Aprelev, Ryan Macnak, Commit Queue, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Alexander Markov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Aug 8, 2025, 11:27:23 AMAug 8
to Alexander Markov, Alexander Aprelev, Ryan Macnak, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm] Fix msvc build
Use standard constant instead of gcc/clang specific extension.
TEST=ci
Change-Id: I4b6a8e2ad62f180bebac39c90fff62cd60857d2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444440
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
- M runtime/vm/compiler/assembler/assembler_arm64.cc
- M runtime/vm/compiler/assembler/assembler_riscv.cc
- M runtime/vm/compiler/assembler/assembler_x64.cc
Change size: S
Delta: 3 files changed, 8 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Aprelev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages