Copybara Prod has uploaded this change for review.
Add access-control-allow-* headers
Closes https://github.com/dart-lang/sdk/pull/45947
https://github.com/dart-lang/sdk/pull/45947
GitOrigin-RevId: 54343958feed6fff573fae67378d0f899078efe6
Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
---
M sdk/lib/_http/http.dart
1 file changed, 3 insertions(+), 0 deletions(-)
diff --git a/sdk/lib/_http/http.dart b/sdk/lib/_http/http.dart
index c20759f..332a74b 100644
--- a/sdk/lib/_http/http.dart
+++ b/sdk/lib/_http/http.dart
@@ -391,6 +391,9 @@
static const acceptEncodingHeader = "accept-encoding";
static const acceptLanguageHeader = "accept-language";
static const acceptRangesHeader = "accept-ranges";
+ static const accessControlAllowHeaders = 'access-control-allow-headers';
+ static const accessControlAllowMethods = 'access-control-allow-methods';
+ static const accessControlAllowOrigin = 'access-control-allow-origin';
static const ageHeader = "age";
static const allowHeader = "allow";
static const authorizationHeader = "authorization";
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.
Copybara Prod uploaded patch set #2 to this change.
Add access-control-allow-* headers
cc @kevmoo if you know who can handle this.
GitOrigin-RevId: af8c15f48a229ad5066a5f74d2bcac45368e9545
Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
---
M sdk/lib/_http/http.dart
1 file changed, 12 insertions(+), 0 deletions(-)
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.
Copybara Prod uploaded patch set #3 to this change.
Add access-control-allow-* headers
cc @kevmoo if you know who can handle this.
Closes https://github.com/dart-lang/sdk/pull/45947
https://github.com/dart-lang/sdk/pull/45947
GitOrigin-RevId: 1779b0c2e028775c2b034967b964fe9ebc49e9f6
Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
---
M sdk/lib/_http/http.dart
1 file changed, 12 insertions(+), 0 deletions(-)
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 3:Code-Review +1Commit-Queue +2
1 comment:
Patchset:
LGTM
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.
Copybara Prod uploaded patch set #4 to this change.
Add access-control-allow-* headers
cc @kevmoo if you know who can handle this.
Closes https://github.com/dart-lang/sdk/pull/45947
https://github.com/dart-lang/sdk/pull/45947
GitOrigin-RevId: ae62a578d11095dd225ecb02f83e29ce5bd99864
Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
---
M sdk/lib/_http/http.dart
1 file changed, 12 insertions(+), 0 deletions(-)
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.
1 comment:
Patchset:
Should this be submitted?
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 4:Code-Review +1Commit-Queue +2
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 5:Code-Review +1Commit-Queue +2
commi...@chromium.org submitted this change.
Add access-control-allow-* headers
cc @kevmoo if you know who can handle this.
Closes https://github.com/dart-lang/sdk/pull/45947
https://github.com/dart-lang/sdk/pull/45947
GitOrigin-RevId: ae62a578d11095dd225ecb02f83e29ce5bd99864
Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198780
Reviewed-by: Lasse R.H. Nielsen <l...@google.com>
Commit-Queue: Lasse R.H. Nielsen <l...@google.com>
---
M pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect
M sdk/lib/_http/http.dart
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect b/pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect
index c139fe9..525fab5 100644
--- a/pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect
+++ b/pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect
@@ -170,8 +170,8 @@
Evaluated: SymbolLiteral @ org-dartlang-testcase:///mock_http_headers.dart:13:7 -> SymbolConstant(#noFolding)
Evaluated: ListLiteral @ org-dartlang-testcase:///mock_http_headers.dart:13:7 -> ListConstant(const <Type*>[])
Evaluated: MapLiteral @ org-dartlang-testcase:///mock_http_headers.dart:13:7 -> InstanceConstant(const _ImmutableMap<Symbol*, dynamic>{_ImmutableMap._kvPairs: const <dynamic>[]})
-Evaluated: SymbolLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:762:8 -> SymbolConstant(#clear)
-Evaluated: ListLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:762:8 -> ListConstant(const <Type*>[])
-Evaluated: ListLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:762:8 -> ListConstant(const <dynamic>[])
-Evaluated: MapLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:762:8 -> InstanceConstant(const _ImmutableMap<Symbol*, dynamic>{_ImmutableMap._kvPairs: const <dynamic>[]})
+Evaluated: SymbolLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:774:8 -> SymbolConstant(#clear)
+Evaluated: ListLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:774:8 -> ListConstant(const <Type*>[])
+Evaluated: ListLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:774:8 -> ListConstant(const <dynamic>[])
+Evaluated: MapLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:774:8 -> InstanceConstant(const _ImmutableMap<Symbol*, dynamic>{_ImmutableMap._kvPairs: const <dynamic>[]})
Extra constant evaluation: evaluated: 268, effectively constant: 91
diff --git a/sdk/lib/_http/http.dart b/sdk/lib/_http/http.dart
index 47e481a..abc401e 100644
--- a/sdk/lib/_http/http.dart
+++ b/sdk/lib/_http/http.dart
@@ -391,6 +391,18 @@
static const acceptEncodingHeader = "accept-encoding";
static const acceptLanguageHeader = "accept-language";
static const acceptRangesHeader = "accept-ranges";
+ static const accessControlAllowCredentialsHeader =
+ 'access-control-allow-credentials';
+ static const accessControlAllowHeadersHeader = 'access-control-allow-headers';
+ static const accessControlAllowMethodsHeader = 'access-control-allow-methods';
+ static const accessControlAllowOriginHeader = 'access-control-allow-origin';
+ static const accessControlExposeHeadersHeader =
+ 'access-control-expose-headers';
+ static const accessControlMaxAgeHeader = 'access-control-max-age';
+ static const accessControlRequestHeadersHeader =
+ 'access-control-request-headers';
+ static const accessControlRequestMethodHeader =
+ 'access-control-request-method';
static const ageHeader = "age";
static const allowHeader = "allow";
static const authorizationHeader = "authorization";
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.
go/dart-cbuild result: SUCCESS
Details: https://goto.google.com/dart-cbuild/find/de999e8ea3610c0b6f6c12afbe168493bad755fa
2 comments:
Patchset:
We should have added changelog entries, too!
File sdk/lib/_http/http.dart:
Patch Set #6, Line 394: static const accessControlAllowCredentialsHeader =
We should have added `@Since` annotations here!
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.
1 comment:
File sdk/lib/_http/http.dart:
Patch Set #6, Line 394: static const accessControlAllowCredentialsHeader =
We should have added `@Since` annotations here!
That too
To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.