Change in dart/sdk[master]: Add access-control-allow-* headers

0 views
Skip to first unread message

Copybara Prod (Gerrit)

unread,
May 7, 2021, 6:01:59 AM5/7/21
to Jonas Termansen, rev...@dartlang.org

Copybara Prod has uploaded this change for review.

View Change

Add access-control-allow-* headers

Closes https://github.com/dart-lang/sdk/pull/45947
https://github.com/dart-lang/sdk/pull/45947

GitOrigin-RevId: 54343958feed6fff573fae67378d0f899078efe6
Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
---
M sdk/lib/_http/http.dart
1 file changed, 3 insertions(+), 0 deletions(-)

diff --git a/sdk/lib/_http/http.dart b/sdk/lib/_http/http.dart
index c20759f..332a74b 100644
--- a/sdk/lib/_http/http.dart
+++ b/sdk/lib/_http/http.dart
@@ -391,6 +391,9 @@
static const acceptEncodingHeader = "accept-encoding";
static const acceptLanguageHeader = "accept-language";
static const acceptRangesHeader = "accept-ranges";
+ static const accessControlAllowHeaders = 'access-control-allow-headers';
+ static const accessControlAllowMethods = 'access-control-allow-methods';
+ static const accessControlAllowOrigin = 'access-control-allow-origin';
static const ageHeader = "age";
static const allowHeader = "allow";
static const authorizationHeader = "authorization";

To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk
Gerrit-Branch: master
Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
Gerrit-Change-Number: 198780
Gerrit-PatchSet: 1
Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
Gerrit-MessageType: newchange

Copybara Prod (Gerrit)

unread,
May 7, 2021, 6:56:13 AM5/7/21
to rev...@dartlang.org

Copybara Prod uploaded patch set #2 to this change.

View Change

Add access-control-allow-* headers

cc @kevmoo if you know who can handle this.
GitOrigin-RevId: af8c15f48a229ad5066a5f74d2bcac45368e9545

Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
---
M sdk/lib/_http/http.dart
1 file changed, 12 insertions(+), 0 deletions(-)

To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk
Gerrit-Branch: master
Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
Gerrit-Change-Number: 198780
Gerrit-PatchSet: 2
Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
Gerrit-MessageType: newpatchset

Copybara Prod (Gerrit)

unread,
May 7, 2021, 2:51:29 PM5/7/21
to rev...@dartlang.org

Copybara Prod uploaded patch set #3 to this change.

View Change

Add access-control-allow-* headers

cc @kevmoo if you know who can handle this.

Closes https://github.com/dart-lang/sdk/pull/45947
https://github.com/dart-lang/sdk/pull/45947

GitOrigin-RevId: 1779b0c2e028775c2b034967b964fe9ebc49e9f6

Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
---
M sdk/lib/_http/http.dart
1 file changed, 12 insertions(+), 0 deletions(-)

To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk
Gerrit-Branch: master
Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
Gerrit-Change-Number: 198780
Gerrit-PatchSet: 3

Lasse R.H. Nielsen (Gerrit)

unread,
Jun 10, 2021, 10:11:17 AM6/10/21
to Copybara Prod, rev...@dartlang.org

Patch set 3:Code-Review +1Commit-Queue +2

View Change

1 comment:

To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk
Gerrit-Branch: master
Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
Gerrit-Change-Number: 198780
Gerrit-PatchSet: 3
Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 14:11:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Copybara Prod (Gerrit)

unread,
Jun 10, 2021, 10:22:02 AM6/10/21
to rev...@dartlang.org

Copybara Prod uploaded patch set #4 to this change.

View Change

Add access-control-allow-* headers

cc @kevmoo if you know who can handle this.

Closes https://github.com/dart-lang/sdk/pull/45947
https://github.com/dart-lang/sdk/pull/45947

GitOrigin-RevId: ae62a578d11095dd225ecb02f83e29ce5bd99864

Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
---
M sdk/lib/_http/http.dart
1 file changed, 12 insertions(+), 0 deletions(-)

To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk
Gerrit-Branch: master
Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
Gerrit-Change-Number: 198780
Gerrit-PatchSet: 4
Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
Gerrit-CC: Dart Reviews <rev...@dartlang.org>
Gerrit-MessageType: newpatchset

Michael Thomsen (Gerrit)

unread,
Aug 3, 2021, 9:59:34 AM8/3/21
to Copybara Prod, rev...@dartlang.org, commi...@chromium.org, Lasse R.H. Nielsen

View Change

1 comment:

To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk
Gerrit-Branch: master
Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
Gerrit-Change-Number: 198780
Gerrit-PatchSet: 4
Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
Gerrit-CC: Dart Reviews <rev...@dartlang.org>
Gerrit-CC: Michael Thomsen <m...@google.com>
Gerrit-Comment-Date: Tue, 03 Aug 2021 13:59:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Lasse R.H. Nielsen (Gerrit)

unread,
Aug 3, 2021, 10:10:23 AM8/3/21
to Copybara Prod, rev...@dartlang.org, Michael Thomsen, commi...@chromium.org

Patch set 4:Code-Review +1Commit-Queue +2

View Change

    To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
    Gerrit-Change-Number: 198780
    Gerrit-PatchSet: 4
    Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
    Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
    Gerrit-CC: Dart Reviews <rev...@dartlang.org>
    Gerrit-CC: Michael Thomsen <m...@google.com>
    Gerrit-Comment-Date: Tue, 03 Aug 2021 14:10:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Lasse R.H. Nielsen (Gerrit)

    unread,
    Aug 5, 2021, 4:59:24 AM8/5/21
    to Copybara Prod, rev...@dartlang.org, Michael Thomsen, commi...@chromium.org

    Patch set 5:Code-Review +1Commit-Queue +2

    View Change

      To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: sdk
      Gerrit-Branch: master
      Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
      Gerrit-Change-Number: 198780
      Gerrit-PatchSet: 5
      Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
      Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
      Gerrit-CC: Dart Reviews <rev...@dartlang.org>
      Gerrit-CC: Michael Thomsen <m...@google.com>
      Gerrit-Comment-Date: Thu, 05 Aug 2021 08:59:20 +0000

      commit-bot@chromium.org (Gerrit)

      unread,
      Aug 5, 2021, 5:48:27 AM8/5/21
      to Lasse R.H. Nielsen, Copybara Prod, rev...@dartlang.org, Michael Thomsen

      commi...@chromium.org submitted this change.

      View Change

      Approvals: Lasse R.H. Nielsen: Looks good to me, approved; Commit
      Add access-control-allow-* headers

      cc @kevmoo if you know who can handle this.

      Closes https://github.com/dart-lang/sdk/pull/45947
      https://github.com/dart-lang/sdk/pull/45947

      GitOrigin-RevId: ae62a578d11095dd225ecb02f83e29ce5bd99864
      Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
      Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198780
      Reviewed-by: Lasse R.H. Nielsen <l...@google.com>
      Commit-Queue: Lasse R.H. Nielsen <l...@google.com>
      ---
      M pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect
      M sdk/lib/_http/http.dart
      2 files changed, 16 insertions(+), 4 deletions(-)

      diff --git a/pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect b/pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect
      index c139fe9..525fab5 100644
      --- a/pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect
      +++ b/pkg/front_end/testcases/nnbd_mixed/mock_http_headers.dart.weak.outline.expect
      @@ -170,8 +170,8 @@
      Evaluated: SymbolLiteral @ org-dartlang-testcase:///mock_http_headers.dart:13:7 -> SymbolConstant(#noFolding)
      Evaluated: ListLiteral @ org-dartlang-testcase:///mock_http_headers.dart:13:7 -> ListConstant(const <Type*>[])
      Evaluated: MapLiteral @ org-dartlang-testcase:///mock_http_headers.dart:13:7 -> InstanceConstant(const _ImmutableMap<Symbol*, dynamic>{_ImmutableMap._kvPairs: const <dynamic>[]})
      -Evaluated: SymbolLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:762:8 -> SymbolConstant(#clear)
      -Evaluated: ListLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:762:8 -> ListConstant(const <Type*>[])
      -Evaluated: ListLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:762:8 -> ListConstant(const <dynamic>[])
      -Evaluated: MapLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:762:8 -> InstanceConstant(const _ImmutableMap<Symbol*, dynamic>{_ImmutableMap._kvPairs: const <dynamic>[]})
      +Evaluated: SymbolLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:774:8 -> SymbolConstant(#clear)
      +Evaluated: ListLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:774:8 -> ListConstant(const <Type*>[])
      +Evaluated: ListLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:774:8 -> ListConstant(const <dynamic>[])
      +Evaluated: MapLiteral @ org-dartlang-sdk:///sdk/lib/_http/http.dart:774:8 -> InstanceConstant(const _ImmutableMap<Symbol*, dynamic>{_ImmutableMap._kvPairs: const <dynamic>[]})
      Extra constant evaluation: evaluated: 268, effectively constant: 91
      diff --git a/sdk/lib/_http/http.dart b/sdk/lib/_http/http.dart
      index 47e481a..abc401e 100644
      --- a/sdk/lib/_http/http.dart
      +++ b/sdk/lib/_http/http.dart
      @@ -391,6 +391,18 @@

      static const acceptEncodingHeader = "accept-encoding";
      static const acceptLanguageHeader = "accept-language";
      static const acceptRangesHeader = "accept-ranges";
      +  static const accessControlAllowCredentialsHeader =
      + 'access-control-allow-credentials';
      + static const accessControlAllowHeadersHeader = 'access-control-allow-headers';
      + static const accessControlAllowMethodsHeader = 'access-control-allow-methods';
      + static const accessControlAllowOriginHeader = 'access-control-allow-origin';
      + static const accessControlExposeHeadersHeader =
      + 'access-control-expose-headers';
      + static const accessControlMaxAgeHeader = 'access-control-max-age';
      + static const accessControlRequestHeadersHeader =
      + 'access-control-request-headers';
      + static const accessControlRequestMethodHeader =
      + 'access-control-request-method';

      static const ageHeader = "age";
      static const allowHeader = "allow";
      static const authorizationHeader = "authorization";

      To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: sdk
      Gerrit-Branch: master
      Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
      Gerrit-Change-Number: 198780
      Gerrit-PatchSet: 6
      Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
      Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
      Gerrit-CC: Dart Reviews <rev...@dartlang.org>
      Gerrit-CC: Michael Thomsen <m...@google.com>
      Gerrit-MessageType: merged

      Dart CI (Gerrit)

      unread,
      Aug 5, 2021, 6:21:10 AM8/5/21
      to commi...@chromium.org, Lasse R.H. Nielsen, Copybara Prod, rev...@dartlang.org, Michael Thomsen

      go/dart-cbuild result: SUCCESS

      Details: https://goto.google.com/dart-cbuild/find/de999e8ea3610c0b6f6c12afbe168493bad755fa

      View Change

        To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: sdk
        Gerrit-Branch: master
        Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
        Gerrit-Change-Number: 198780
        Gerrit-PatchSet: 6
        Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
        Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
        Gerrit-CC: Dart Reviews <rev...@dartlang.org>
        Gerrit-CC: Michael Thomsen <m...@google.com>
        Gerrit-Comment-Date: Thu, 05 Aug 2021 10:21:06 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No
        Gerrit-MessageType: comment

        Kevin Moore (Gerrit)

        unread,
        Aug 5, 2021, 4:30:50 PM8/5/21
        to commi...@chromium.org, Lasse R.H. Nielsen, Copybara Prod, rev...@dartlang.org, Dart CI, Michael Thomsen

        View Change

        2 comments:

        • Patchset:

        • File sdk/lib/_http/http.dart:

          • Patch Set #6, Line 394: static const accessControlAllowCredentialsHeader =

            We should have added `@Since` annotations here!

        To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: sdk
        Gerrit-Branch: master
        Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
        Gerrit-Change-Number: 198780
        Gerrit-PatchSet: 6
        Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
        Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
        Gerrit-CC: Dart Reviews <rev...@dartlang.org>
        Gerrit-CC: Kevin Moore <kev...@google.com>
        Gerrit-CC: Michael Thomsen <m...@google.com>
        Gerrit-Comment-Date: Thu, 05 Aug 2021 20:30:47 +0000

        Lasse R.H. Nielsen (Gerrit)

        unread,
        Aug 6, 2021, 8:59:02 AM8/6/21
        to commi...@chromium.org, Copybara Prod, rev...@dartlang.org, Kevin Moore, Dart CI, Michael Thomsen

        View Change

        1 comment:

        • File sdk/lib/_http/http.dart:

          • Patch Set #6, Line 394: static const accessControlAllowCredentialsHeader =

            We should have added `@Since` annotations here!

          • That too

        To view, visit change 198780. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: sdk
        Gerrit-Branch: master
        Gerrit-Change-Id: If56f362b92c9226e94a8ea29b162de21ca548710
        Gerrit-Change-Number: 198780
        Gerrit-PatchSet: 6
        Gerrit-Owner: Copybara Prod <copybara-wor...@google.com>
        Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
        Gerrit-CC: Dart Reviews <rev...@dartlang.org>
        Gerrit-CC: Kevin Moore <kev...@google.com>
        Gerrit-CC: Michael Thomsen <m...@google.com>
        Gerrit-Comment-Date: Fri, 06 Aug 2021 12:58:59 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Kevin Moore <kev...@google.com>
        Gerrit-MessageType: comment
        Reply all
        Reply to author
        Forward
        0 new messages