[M] Change in dart/sdk[main]: Fix a bug where renaming a field formal parameter would not rename th...
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Dec 22, 2025, 5:53:56 PM (2 days ago) Dec 22
to Fedor Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Fedor Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jaime Wren (Gerrit)
Dec 22, 2025, 5:56:59 PM (2 days ago) Dec 22
to Fedor Shcheglov, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov
Jaime Wren voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Fedor Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 22, 2025, 5:58:10 PM (2 days ago) Dec 22
to Fedor Shcheglov, Jaime Wren, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Fedor Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 22, 2025, 5:58:23 PM (2 days ago) Dec 22
to Fedor Shcheglov, Jaime Wren, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix a bug where renaming a field formal parameter would not rename the field formal parameter in subclasses or superclasses.
Change-Id: I43a11195e08b66b561e7bb163a62d00bb5c3dc03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/469520
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Jaime Wren <jw...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/refactoring/legacy/rename_class_member.dart
- M pkg/analysis_server/test/services/refactoring/legacy/rename_class_member_test.dart
Change size: M
Delta: 2 files changed, 134 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov, +1 by Jaime Wren
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages